Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml #2991

Merged
merged 2 commits into from Jun 16, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 3, 2023

Description

Update the obs4MIPs dataset to the latest naming scheme in recipe_smpi.yml. The pull request is labeled as backward incompatible because this will require moving or linking the obs4MIPs data to a directory with the new dataset name or downloading it from ESGF.

Fixes part of #2974


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@bouweandela bouweandela changed the title Update dataset names Update obs4MIPs datasets to the latest version in recipe_smpi.yml Jan 3, 2023
@bouweandela bouweandela changed the title Update obs4MIPs datasets to the latest version in recipe_smpi.yml Update obs4MIPs dataset to the latest version in recipe_smpi.yml Jan 3, 2023
@bouweandela bouweandela changed the title Update obs4MIPs dataset to the latest version in recipe_smpi.yml Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml Jan 3, 2023
@bouweandela bouweandela added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jan 5, 2023
@bouweandela bouweandela added this to the v2.8.0 milestone Jan 5, 2023
@bouweandela bouweandela removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Mar 13, 2023
@bouweandela bouweandela modified the milestones: v2.8.0, v2.9.0 Mar 13, 2023
@bouweandela bouweandela marked this pull request as ready for review March 13, 2023 09:48
Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bouweandela,
your changes look fine to me.

@bouweandela
Copy link
Member Author

Let's merge this then and we can do further testing as part of the release.

@bouweandela bouweandela merged commit 2b34d9f into main Jun 16, 2023
@bouweandela bouweandela deleted the update-obs4mips-smpi branch June 16, 2023 11:25
ehogan added a commit that referenced this pull request Jun 26, 2023
…old_and_clone_task_rtw

* recipe_test_workflow_prototype: (199 commits)
  #3169: Upgrade the RTW to work with ESMValTool v2.8.0
  [Condalock] Update Linux condalock file (#3237)
  Modified links to the tutorial (#3236)
  Add ESMValCore release `v2.8.1` into the documentation (#3235)
  Generate climatology on the fly for AutoAssess soil moisture (#3197)
  New recipe and diagnostic for Arctic-midlatitude research (#3021)
  Fixed pandas diagnostics for pandas>=2.0.0 (#3209)
  Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991)
  Add variable long names to provenance record in monitoring diagnostics (#3222)
  Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167)
  Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212)
  [Condalock] Update Linux condalock file (#3217)
  Add Seaborn diagnostic (#3155)
  Remove fx_variables from ipccwg1ar5ch9 recipes (#3215)
  Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211)
  Update recipe_impact.yml to work with newer versions of `pandas` (#3220)
  Use ESMValCore v2.9.0 release candidates (#3219)
  [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213)
  New plot_type 1d_profile in monitor  (#3178)
  Add support for using a dask distributed scheduler (#3151)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants