Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) #3167

Merged
merged 7 commits into from Jun 14, 2023

Conversation

axel-lauer
Copy link
Contributor

@axel-lauer axel-lauer commented May 4, 2023

Description

This PR extends the downloading and formatting scripts for the NASA MERRA2 reanalysis by adding the following variables:

  • cl
  • cli
  • clivi
  • clw
  • clwvi

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated data reformatting script

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool, cheers muchly @axel-lauer 🍺 If you got a bit of time, could you maybe add a test case that converts the units to Pa? No biggie if not, most other cmorizers don't have tests attached, but I thought I'd create a nice start to add tests when I plopped the original cmorizer stuff here 👍

@axel-lauer
Copy link
Contributor Author

Thanks @valeriupredoi for the review! I just included the unit conversion of the vertical coordinate from hPa to Pa in the tests. Thanks for the good suggestion.

@valeriupredoi
Copy link
Contributor

awesome, very many thanks @axel-lauer 🍺 Let's wait for @remi-kazeroni to come back from the hols and get this in for 2.9 👍 Could you pls clean up the PR description (tick/remove boxes etc)

@valeriupredoi valeriupredoi added this to the v2.9.0 milestone Jun 5, 2023
@axel-lauer
Copy link
Contributor Author

Cleaned up the PR description (tick/remove boxes etc)...

@valeriupredoi
Copy link
Contributor

cheers muchly @axel-lauer 🍺 @remi-kazeroni when you back from sunny beaches, could give this a spin, pls bud 🍺

@remi-kazeroni remi-kazeroni changed the title Extension of NASA MERRA2 CMORizer Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) Jun 14, 2023
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @axel-lauer! All works fine and code looks good. 👍

The new MERRA2 data (raw and CMORized) are stored in the shared directories on Levante, so I'm merging this PR

@remi-kazeroni remi-kazeroni merged commit e17d1c8 into main Jun 14, 2023
6 checks passed
@remi-kazeroni remi-kazeroni deleted the cmorizer_nasa_merra2_extension branch June 14, 2023 15:40
ehogan added a commit that referenced this pull request Jun 26, 2023
…old_and_clone_task_rtw

* recipe_test_workflow_prototype: (199 commits)
  #3169: Upgrade the RTW to work with ESMValTool v2.8.0
  [Condalock] Update Linux condalock file (#3237)
  Modified links to the tutorial (#3236)
  Add ESMValCore release `v2.8.1` into the documentation (#3235)
  Generate climatology on the fly for AutoAssess soil moisture (#3197)
  New recipe and diagnostic for Arctic-midlatitude research (#3021)
  Fixed pandas diagnostics for pandas>=2.0.0 (#3209)
  Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991)
  Add variable long names to provenance record in monitoring diagnostics (#3222)
  Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167)
  Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212)
  [Condalock] Update Linux condalock file (#3217)
  Add Seaborn diagnostic (#3155)
  Remove fx_variables from ipccwg1ar5ch9 recipes (#3215)
  Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211)
  Update recipe_impact.yml to work with newer versions of `pandas` (#3220)
  Use ESMValCore v2.9.0 release candidates (#3219)
  [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213)
  New plot_type 1d_profile in monitor  (#3178)
  Add support for using a dask distributed scheduler (#3151)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants