Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pandas diagnostics for pandas>=2.0.0 #3209

Merged
merged 4 commits into from Jun 19, 2023
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 6, 2023

Description

Closes #3196.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added the bug label Jun 6, 2023
@schlunma schlunma added this to the v2.9.0 milestone Jun 6, 2023
@schlunma schlunma self-assigned this Jun 6, 2023
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastest review ever? 😁

@valeriupredoi
Copy link
Contributor

quick - make it RfR, otherwise I will incur the eternal wrath of @zklaus 🤣

@schlunma
Copy link
Contributor Author

schlunma commented Jun 6, 2023

Will do once the recipes ran successfully 😅

@valeriupredoi
Copy link
Contributor

docs build fails on RTD - and it looks like a transitory hiccup so not a worry

@schlunma
Copy link
Contributor Author

schlunma commented Jun 6, 2023

I found a iris issue (introduced by myself 😅) that leads to other errors when running some of these recipes (SciTools/iris#5339). I already provided a fix for this in SciTools/iris#5340.

I think the pandas-related issues are fixed by this PR, though.

@valeriupredoi
Copy link
Contributor

OK RTD build issue was indeed a fluke 🥳

zklaus
zklaus previously requested changes Jun 8, 2023
Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Two suggestions for streamlining the concatenation.

esmvaltool/diag_scripts/climate_metrics/create_table.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/climate_metrics/create_table.py Outdated Show resolved Hide resolved
@schlunma schlunma marked this pull request as ready for review June 10, 2023 08:22
@schlunma
Copy link
Contributor Author

All affected recipes run successfully now (with SciTools/iris#5340) 🚀

@remi-kazeroni
Copy link
Contributor

@zklaus - it looks to me that your previous comments were addressed by @schlunma. Would you have further comments on this PR? If not, could you please approve and merge? It would great to have this in soon in order to ease the recipe testing a little

@bouweandela bouweandela merged commit 5c6ccd5 into main Jun 19, 2023
6 checks passed
@bouweandela bouweandela deleted the fix_pandas_diag branch June 19, 2023 06:53
ehogan added a commit that referenced this pull request Jun 26, 2023
…old_and_clone_task_rtw

* recipe_test_workflow_prototype: (199 commits)
  #3169: Upgrade the RTW to work with ESMValTool v2.8.0
  [Condalock] Update Linux condalock file (#3237)
  Modified links to the tutorial (#3236)
  Add ESMValCore release `v2.8.1` into the documentation (#3235)
  Generate climatology on the fly for AutoAssess soil moisture (#3197)
  New recipe and diagnostic for Arctic-midlatitude research (#3021)
  Fixed pandas diagnostics for pandas>=2.0.0 (#3209)
  Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991)
  Add variable long names to provenance record in monitoring diagnostics (#3222)
  Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167)
  Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212)
  [Condalock] Update Linux condalock file (#3217)
  Add Seaborn diagnostic (#3155)
  Remove fx_variables from ipccwg1ar5ch9 recipes (#3215)
  Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211)
  Update recipe_impact.yml to work with newer versions of `pandas` (#3220)
  Use ESMValCore v2.9.0 release candidates (#3219)
  [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213)
  New plot_type 1d_profile in monitor  (#3178)
  Add support for using a dask distributed scheduler (#3151)
  ...
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostic failures due to latest version of pandas
5 participants