Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST client: Cannot add options #38

Closed
merretbuurman opened this issue Nov 11, 2021 · 5 comments
Closed

REST client: Cannot add options #38

merretbuurman opened this issue Nov 11, 2021 · 5 comments
Assignees

Comments

@merretbuurman
Copy link
Collaborator

Sometimes I need the option ?auth in GET requests to make sure the primary server is requested. I cannot pass that.

@merretbuurman
Copy link
Collaborator Author

I added the auth options (and other params accepted by HTTP GET to the methods that read handle records.
But if you pass it to the methods that write records, it is taken as one of the key-value-pairs that users want to register, so it will be added to the handle record:

URL = www.dkrz.de
VERSION = 23
auth = True

That is hardly desired. But if we delete any auth passed by the user, then users cannot register that as a key-value pair anymore, even if that's intended. Hm. Any thoughts?

Obviously we could add another parameter, e.g. force_add or so... But that might be over the top.

@merretbuurman
Copy link
Collaborator Author

(Except for that last comment, the things were done in #65 ).

@themiszamani
Copy link
Collaborator

We are going to support the auth options in the read handle records.
The documentation informs the users that all the values they pass in the that write records, are taken as key-value-pairs and will be added to the handle record.

@merretbuurman
Copy link
Collaborator Author

I just noticed that "type" can be repeated, so I need to pass it differently than in this PR. Please wait with merging, thanks!

@themiszamani
Copy link
Collaborator

#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants