Add ignored directories option and bug fix. #93
Conversation
|
Thanks, I will check it out. |
| }); | ||
| AddOption(new Option(new[] { "--ignore-directories" }, "Ignore directories when searching files. Example: -ignore-directories Folder1,Folder2") | ||
| { | ||
| Argument = new Argument<string>() |
There was a problem hiding this comment.
It's better to use string[] type instead of a single string, so that we need not to worry about the format of the option.(CLI library will check it automatically)
See:
|
|
||
| var ignored = ignoredDirectories? | ||
| .Split(new[] { ',', ';' }, StringSplitOptions.RemoveEmptyEntries) | ||
| .Select(x => Path.Combine(baseDirectory, x)).ToArray() ?? Array.Empty<string>(); |
There was a problem hiding this comment.
Does the ignored directories have to be directly under the BaseDirectory?
Can they be arbitrary depth?
For example, If I use --ignore-directories IgnoreDir, can the directory C:\BaseDirectory\aspnet-core\src\MyAbp.Domain\*IgnoreDir* be ignored?
|
|
||
| TemplateType templateType; | ||
| if (Directory.EnumerateFiles(baseDirectory, "*.DbMigrator.csproj", SearchOption.AllDirectories).Any()) | ||
| if (Directory.EnumerateFiles(baseDirectory, "*.DbMigrator.csproj", SearchOption.AllDirectories).Any(x => !ignored.Any(x.StartsWith))) |
There was a problem hiding this comment.
Since this usage repeats for many times, I think it's better to extract an extension method, e.g:
EnumerateFiles(this Directory directory, ... , string[] ignoreDirectories)
| step => | ||
| .Then<IfElse>( | ||
| ie => ie.ConditionExpression = new JavaScriptExpression<bool> | ||
| ("ProjectInfo.UiFramework == 1"), |
There was a problem hiding this comment.
Use explicit enum instead of magic number, like:
($"ProjectInfo.UiFramework == {UiFramework.RazorPages.ToString("D")}")
| }) | ||
| .Then<IfElse>( | ||
| ie => ie.ConditionExpression = new JavaScriptExpression<bool> | ||
| ("ProjectInfo.UiFramework == 0"), |
|
Wow, it becomes a huge PR. |
--ignored-directoriesoption: ignore directories when searching files.