Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add store's owner #68

Closed
RayMMond opened this issue Jun 26, 2020 · 2 comments · Fixed by #81
Closed

Add store's owner #68

RayMMond opened this issue Jun 26, 2020 · 2 comments · Fixed by #81
Assignees
@RayMMond
Labels
module-stores
Milestone
1.0.0

Comments

@RayMMond
Copy link
Member

Store need a owner id property to manage any store-related permissions.
@gdlcf88
Copy link
Member

gdlcf88 commented Jun 26, 2020 •
edited
Loading

Store.OwnerUserId is not enough, maybe it is better to design a StoreOwner aggregate root.

Implementing multi-store is a difficult job, there are more problems that should be resolved, such as owners' permissions. I will spend more time thinking about it.

@RayMMond RayMMond mentioned this issue Jun 27, 2020
Closed
@gdlcf88 gdlcf88 mentioned this issue Jul 30, 2020
Closed
@gdlcf88
Copy link
Member

gdlcf88 commented Jul 30, 2020 •
edited
Loading

We can check if the current user is one of the owners of the store, see #17.

Should also introduce IStoreOwnerStore to provide cached information.

@gdlcf88 gdlcf88 added this to the 1.0.0 milestone Jul 30, 2020
@RayMMond RayMMond mentioned this issue Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RayMMond RayMMond

Labels
module-stores
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add store owner RayMMond/EShop
2 participants
@RayMMond @gdlcf88