bug #6126 Don't translate form values that are already translated (ja…

…viereguiluz)

This PR was merged into the 4.x branch.

Discussion
----------

Don't translate form values that are already translated

In #6121 we fixed this problem for countries ... but other form types also pass their values translated to the template, so let's not translate any of them.

Commits
-------

584a7e6 Don't translate form values that are already translated

src/Field/Configurator/CurrencyConfigurator.php

@@ -23,6 +23,8 @@ public function supports(FieldDto $field, EntityDto $entityDto): bool
     public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $context): void
     {
         $field->setFormTypeOptionIfNotSet('attr.data-ea-widget', 'ea-autocomplete');
+        // currency names passed to the form are already translated, so don't translate them again in the template
+        $field->setFormTypeOptionIfNotSet('choice_translation_domain', false);
 
         if (null === $currencyCode = $field->getValue()) {
             return;

src/Field/Configurator/LanguageConfigurator.php

@@ -35,6 +35,8 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
                 $field->getCustomOption(LanguageField::OPTION_LANGUAGE_CODES_TO_REMOVE))
             );
             $field->setFormTypeOption('choice_loader', null);
+            // language names passed to the form are already translated, so don't translate them again in the template
+            $field->setFormTypeOptionIfNotSet('choice_translation_domain', false);
         }
 
         if (null === $languageCode = $field->getValue()) {

src/Field/Configurator/LocaleConfigurator.php

@@ -28,6 +28,8 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
         if (\in_array($context->getCrud()->getCurrentPage(), [Crud::PAGE_EDIT, Crud::PAGE_NEW], true)) {
             $field->setFormTypeOption('choices', $this->generateFormTypeChoices($field->getCustomOption(LocaleField::OPTION_LOCALE_CODES_TO_KEEP), $field->getCustomOption(LocaleField::OPTION_LOCALE_CODES_TO_REMOVE)));
             $field->setFormTypeOption('choice_loader', null);
+            // locale names passed to the form are already translated, so don't translate them again in the template
+            $field->setFormTypeOptionIfNotSet('choice_translation_domain', false);
         }
 
         if (null === $localeCode = $field->getValue()) {

src/Field/Configurator/TimezoneConfigurator.php

@@ -22,5 +22,7 @@ public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $c
     {
         $field->setFormTypeOptionIfNotSet('attr.data-ea-widget', 'ea-autocomplete');
         $field->setFormTypeOptionIfNotSet('intl', true);
+        // timezone names passed to the form are already translated, so don't translate them again in the template
+        $field->setFormTypeOptionIfNotSet('choice_translation_domain', false);
     }
 }