Fix an issue related to the translation of country names #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
javiereguiluz
added a commit
that referenced
this pull request
Feb 2, 2024
…viereguiluz) This PR was merged into the 4.x branch. Discussion ---------- Don't translate form values that are already translated In #6121 we fixed this problem for countries ... but other form types also pass their values translated to the template, so let's not translate any of them. Commits ------- 584a7e6 Don't translate form values that are already translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psihius reported this problem to me. When using a
CountryField, you get hundreds of "missing translation" errors. We already pass the country names translated to the form, so there's no need to try to translate them again.