Skip to content

Commit

Permalink
minor #4253 Fixing minor PHPDoc error causing static analysis to fail…
Browse files Browse the repository at this point in the history
… (liarco)

This PR was merged into the 3.0.x-dev branch.

Discussion
----------

Fixing minor PHPDoc error causing static analysis to fail

Hi,
I'm getting errors from PHPStan when I use the `setMenuItems(...)` method from `EasyCorp\Bundle\EasyAdminBundle\Config\UserMenu` like this:
```php
// My dashboard controller
// ...
    public function configureUserMenu(UserInterface $user): UserMenu
    {
        return parent::configureUserMenu($user)
            ->setName($user->getUsername())
            ->setGravatarEmail($user->getUsername())
            ->setMenuItems([MenuItem::linkToLogout('__ea__user.sign_out', 'fa fa-sign-out')])
        ;
    }
// ...
```

The analysis output says:
```
Parameter #1 $items of method EasyCorp\Bundle\EasyAdminBundle\Config\UserMenu::setMenuItems() expects array<EasyCorp\Bundle\EasyAdminBundle\Config\MenuItem>, array<int, EasyCorp\Bundle\EasyAdminBundle\Config\Menu\LogoutMenuItem> given.
```

I think that this minor PHPDoc change should fix that.

What do you think?

Commits
-------

befe94b Fixing minor PHPDoc error causing static analysis to fail
  • Loading branch information
javiereguiluz committed Mar 18, 2021
2 parents 5a08cb6 + befe94b commit d1a73cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Config/UserMenu.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function addMenuItems(array $items): self
}

/**
* @param MenuItem[] $items
* @param MenuItemInterface[] $items
*/
public function setMenuItems(array $items): self
{
Expand Down

0 comments on commit d1a73cf

Please sign in to comment.