Allow easier override of the "new" action. #223
Conversation
|
@Pierstoval thanks for this proposal. Indeed it's useful, so I'm going to merge it right away. Moreover, I want to improve the way we override things so this method will be very useful for that. Thanks! |
This PR was merged into the master branch.
Discussion
----------
Allow easier override of the "new" action.
With this commit, we can easily customize the instanciation of our entities.
I'm proposing this modification because we have a specific case in which we only want to add default contents in a brand new instanciated object, but the content is retrieved via webservice, so I'm doing it in the controller.
Also, this simple workaround allows the users to override the method and create new `User` entity in the FOSUserBundle by returning a new User object using the
`$this->container->get('fos_user.user_manager')->createUser()` instruction.
I think this is useful 😃
Commits
-------
a937046 Added an "instanciateNewEntity" controller method
|
We have a really huge new project at work and I succeeded in convincing my colleagues to use EasyAdmin, so don't worry, I'll certainly have A LOT of new proposals :D |
|
Great! As always, I only ask you one thing: if you are gonna propose a big change, please consider opening first an issue to discuss about it instead of spending a lot of time working on a pull request. Thanks. |
|
Yep, no problem for that! For this PR, it was mainly discussed in #22 , and in fact, this workaround is the best possible solution to make everyone happy with the constructor issue :) |
|
By the way, there was a very minor typo in the name of the method. It's been fixed in 5a11343 |
|
Language barrier, thanks for fixing 👍 |
With this commit, we can easily customize the instanciation of our entities.
I'm proposing this modification because we have a specific case in which we only want to add default contents in a brand new instanciated object, but the content is retrieved via webservice, so I'm doing it in the controller.
Also, this simple workaround allows the users to override the method and create new
Userentity in the FOSUserBundle by returning a new User object using the$this->container->get('fos_user.user_manager')->createUser()instruction.I think this is useful 😃