Allow Symfony 5 #2970
Merged
Allow Symfony 5 #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
previously approved these changes
Oct 22, 2019
|
Wait , don't merge yet :) |
yceruto
reviewed
Oct 22, 2019
nicolas-grekas
commented
Oct 23, 2019
|
PR is green and ready. |
yceruto
approved these changes
Oct 23, 2019
| if (trait_exists(MailerAssertionsTrait::class)) { | ||
| $loader->load(function (ContainerBuilder $container) { | ||
| $container->loadFromExtension('twig', [ | ||
| 'exception_controller' => null, |
There was a problem hiding this comment.
if we can limit this config to 4.4.* strictly, could we remove then this (symfony/symfony#34062) workaround ?
There was a problem hiding this comment.
I think symfony/symfony#34062 is important on its own. The less painful the upgrade path the better!
javiereguiluz
approved these changes
Oct 23, 2019
javiereguiluz
added a commit
that referenced
this pull request
Oct 23, 2019
This PR was merged into the 2.x branch. Discussion ---------- Allow Symfony 5 Related to doctrine/DoctrineFixturesBundle#297 Commits ------- 32b8917 Allow Symfony 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to doctrine/DoctrineFixturesBundle#297