imagine_filter fail when lazy mode is enabled #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoann-TYT
changed the title
ea_apply_filter_if_exists('imagine_filter', formTypeOptions.imagine_pattern) fail when lazy mode is enabled
Yoann-TYT
changed the title
ea_apply_filter_if_exists('imagine_filter', formTypeOptions.imagine_pattern) fail when lazy mode is enabled
javiereguiluz
force-pushed
the
fix_lazy_filter_imagine
branch
from
883562f
to
bb2f839
Compare
|
Yoann, thanks for this fantastic bug fix and for the perfect explanation! While merging I did a minor tweak (4eea6ae) because I prefer to always use strict comparisons. Cheers! |
|
I also prefer to use strict comparisons. Thanks for your great reactivity ! |
javiereguiluz
added a commit
that referenced
this pull request
Jun 22, 2023
This PR was squashed before being merged into the 4.x branch.
Discussion
----------
[Chore] Fix phpstan issues
This PR will fix several `PHPStan` issues:
- [x] Fix `Cannot unset offset string on array<int, EasyCorp\Bundle\EasyAdminBundle\Dto\ActionDto>.`
- [x] Fix `Variable method call on Twig\Extension\RuntimeExtensionInterface.`
- [x] Refactor `EasyAdminTwigExtension::applyFilterIfExists`
- [x] Add integration tests for `applyFilterIfExists`. Issues #3762 and #4808 have been taken into consideration.
- [x] Update parameter type declaration of `Action::new`. We can't use ``@var`` to annotate a parameter. See: https://phpstan.org/r/7695e922-db7f-42b3-ac4f-8ff65a8a37b9
- [x] Modify incorrect PHPDoc. See: https://phpstan.org/r/df4eb1c2-7286-4aa7-b276-f36ff2c0c82c
These issues are a little bit tricky. Both `TranslatableMessageBuilder::withParameters` and `TranslatableChoiceMessage::__toString` are not compatible with `TranslatableInterface`. Those functions should depend on `TranslatableMessage`.
```txt
------ -----------------------------------------------------------------------
Line Field/Configurator/ChoiceConfigurator.php
------ -----------------------------------------------------------------------
124 Parameter #1 $message of class
EasyCorp\Bundle\EasyAdminBundle\Translation\TranslatableChoiceMessage
constructor expects
Symfony\Component\Translation\TranslatableMessage,
Symfony\Contracts\Translation\TranslatableInterface given.
------ -----------------------------------------------------------------------
------ -----------------------------------------------------------------------
Line Translation/TranslatableMessageBuilder.php
------ -----------------------------------------------------------------------
28 Call to an undefined method
Symfony\Contracts\Translation\TranslatableInterface::getMessage().
29 Call to an undefined method
Symfony\Contracts\Translation\TranslatableInterface::getParameters().
30 Call to an undefined method
Symfony\Contracts\Translation\TranslatableInterface::getDomain().
------ -----------------------------------------------------------------------
```
Commits
-------
053f62c [Chore] Fix phpstan issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody !
The problem occurs when I use the VichImageType and its form widget associated.
This line
ea_apply_filter_if_exists('imagine_filter', formTypeOptions.imagine_pattern)fail.I got the error
Non-static method Liip\ImagineBundle\Templating\LazyFilterRuntime::filter() cannot be called staticallywhen liip_imagine is configurered in lazy modeEverything works very well if this mode is disabled.
You can reproduce that problem with the current version of Symfony ( 5.3 ) with php 8.
Just a more complex problem, getFilter is marked as internal by Twig twigphp/Twig#1889
So, we shouldn't use it... but I don't see how to avoid it :-/
I also changed the strict comparison, because on version 2 getFilter can return false but on version 3 it can return null.
Thanks a lot for your review :)