marked some Twig_Environment methods as being internal #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
more-internal-methods
branch
2 times, most recently
from
66e842c
to
12689eb
Compare
|
Assetic relies on |
|
@stof any news on this one? |
|
I haven't worked on Assetic again. I will need to do it (I forgot about this discussion) |
|
@fabpot I did the change in Assetic (was even easier than I though actually). See the PR linked above |
fabpot
force-pushed
the
more-internal-methods
branch
from
12689eb
to
ec80345
Compare
fabpot
force-pushed
the
more-internal-methods
branch
from
ec80345
to
212730a
Compare
|
Thanks @stof |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
…(fabpot) This PR was merged into the 1.x branch. Discussion ---------- marked some Twig_Environment methods as being internal This PR marks some `Twig_Environment` methods as being internals: * `getFunctions()`, `getFilters()`, `getTests()`, `getFunction()`, `getFilter()`, `getTest()`, `getTokenParsers()`, `getTags()`, `getNodeVisitors()`, `getUnaryOperators()`, `getBinaryOperators()` because I don't see how they can be used in any useful way and anyway, `getFunctions()` and `getFilters()` do not return all possible functions or filters. Moreover, I think that all this logic could be refactored and moved into its own class for 2.0 (could be done by deprecating those existing methods in 1.x if we agree to merge this PR). * `getGlobals()` because it should only be called in a runtime context, not in a compilation one (so limiting its usage to internal use only allows for better control of usage). * `initGlobals()`, `initExtensions()`, `initExtension()` because they are private in Twig 2.0. Commits ------- 212730a marked some Twig_Environment methods as being internal
stof
added a commit
to kriswallsmith/assetic
that referenced
this pull request
Nov 11, 2016
…tic functions (stof) This PR was merged into the 1.4-dev branch. Discussion ---------- Avoid using Twig_Environment::getFunction to identify Assetic functions As of Assetic 1.3.0, the Twig functions are using a special node class, which can be used to identify them instead. The `getFunction` method is intended to be marked as an internal one in twigphp/Twig#1889 Commits ------- 39b99e8 Avoid using Twig_Environment::getFunction to identify Assetic functions
javiereguiluz
added a commit
to EasyCorp/EasyAdminBundle
that referenced
this pull request
Nov 17, 2021
This PR was squashed before being merged into the 3.0.x-dev branch.
Discussion
----------
imagine_filter fail when lazy mode is enabled
Hi everybody !
The problem occurs when I use the VichImageType and its form widget associated.
This line `ea_apply_filter_if_exists('imagine_filter', formTypeOptions.imagine_pattern)` fail.
I got the error `Non-static method Liip\ImagineBundle\Templating\LazyFilterRuntime::filter() cannot be called statically` when liip_imagine is configurered in lazy mode
```yaml
# liip_imagine.yaml
liip_imagine:
twig:
mode: 'lazy'
```
Everything works very well if this mode is disabled.
You can reproduce that problem with the current version of Symfony ( 5.3 ) with php 8.
Just a more complex problem, getFilter is marked as internal by Twig twigphp/Twig#1889
So, we shouldn't use it... but I don't see how to avoid it :-/
I also changed the strict comparison, because on version 2 getFilter can return false but on version 3 it can return null.
Thanks a lot for your review :)
Commits
-------
bb2f839 imagine_filter fail when lazy mode is enabled
|
I'm working own a custom twig lexer in order to lint twig files and I need to access the unary operator and the binary operator of the TwigEnvironnement, in order to do a similar logic than the Twig Lexer Those methods are internal, and are just doing Would it be ok to remove |
|
Please open a dedicated discussion instead of commenting on a PR that was merged almost 7 years ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks some
Twig_Environmentmethods as being internals:getFunctions(),getFilters(),getTests(),getFunction(),getFilter(),getTest(),getTokenParsers(),getTags(),getNodeVisitors(),getUnaryOperators(),getBinaryOperators()because I don't see how they can be used in any useful way and anyway,getFunctions()andgetFilters()do not return all possible functions or filters. Moreover, I think that all this logic could be refactored and moved into its own class for 2.0 (could be done by deprecating those existing methods in 1.x if we agree to merge this PR).getGlobals()because it should only be called in a runtime context, not in a compilation one (so limiting its usage to internal use only allows for better control of usage).initGlobals(),initExtensions(),initExtension()because they are private in Twig 2.0.