Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error page can't be rendered without the context #5674

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

simoheinonen
Copy link
Contributor

Uncaught PHP Exception EasyCorp\Bundle\EasyAdminBundle\Exception\EntityNotFoundException: "The "App\Entity\Order" entity with "orderId = " does not exist in the database. The entity may have been deleted by mistake or by a "cascade={"remove"}" operation executed by Doctrine." at /app/vendor/easycorp/easyadmin-bundle/src/Factory/EntityFactory.php line 153
Uncaught Error: Symfony\Bridge\Twig\Extension\AssetExtension::getAssetUrl(): Argument #1 ($path) must be of type string, null given, called in /app/var/cache/prod/twig/ff/ffe222c63463562719428a9eb08ba9a2.php on line 206
Uncaught PHP Exception TypeError: "Symfony\Bridge\Twig\Extension\AssetExtension::getAssetUrl(): Argument #1 ($path) must be of type string, null given, called in /app/var/cache/prod/twig/ff/ffe222c63463562719428a9eb08ba9a2.php on line 206" at /app/vendor/symfony/twig-bridge/Extension/AssetExtension.php line 46

In production EntityNotFoundException turns from 404 into 500 because the rendering failed here. Pretty annoying because 404s can just be ignored but 500 is something that should probably be looked at.

There's also #5477 which fixes this but this is should be a lot simpler

@javiereguiluz javiereguiluz added this to the 4.x milestone Apr 5, 2023
@javiereguiluz
Copy link
Collaborator

@simoheinonen thanks for fixing this and sorry it took me so long to fix this.

The error pages still don't fully work for me (I'm trying to find out why), but your PR solves other issues, so let's merge it.

@javiereguiluz javiereguiluz merged commit 1d0abe0 into EasyCorp:4.x Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants