- Can update a Webhook without parameters (#471)

- Fix ordering of parameters in docstrings
EasyPost · May 12, 2023 · 11b4926 · 11b4926
1 parent 1ffd795
commit 11b4926
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/EasyPost.Tests/ServicesTests/WebhookServiceTest.cs b/EasyPost.Tests/ServicesTests/WebhookServiceTest.cs
@@ -161,7 +161,7 @@ public async Task TestUpdate()
                 Thread.Sleep(10000); // Wait enough time to process
             }
 
-            webhook = await Client.Webhook.Update(webhook.Id);
+            webhook = await Client.Webhook.Update(webhook.Id, new Dictionary<string, object>());
 
             Assert.IsType<Webhook>(webhook);
             Assert.StartsWith("hook_", webhook.Id);

diff --git a/EasyPost/Services/WebhookService.cs b/EasyPost/Services/WebhookService.cs
@@ -92,8 +92,8 @@ public async Task<Webhook> Create(Parameters.Webhook.Create parameters, Cancella
         ///     Enable a disabled <see cref="Webhook"/> or alter its secret.
         ///     <a href="https://www.easypost.com/docs/api#update-a-webhook">Related API documentation</a>.
         /// </summary>
-        /// <param name="parameters">Data to update <see cref="Webhook"/> with.</param>
         /// <param name="id">The ID of the <see cref="Webhook"/> to update.</param>
+        /// <param name="parameters">Data to update <see cref="Webhook"/> with.</param>
         /// <param name="cancellationToken"><see cref="CancellationToken"/> to use for the HTTP request.</param>
         /// <returns>The updated <see cref="Webhook"/>.</returns>
         [CrudOperations.Update]
@@ -106,14 +106,14 @@ public async Task<Webhook> Update(string id, Dictionary<string, object>? paramet
         ///     Enable a disabled <see cref="Webhook"/> or alter its secret.
         ///     <a href="https://www.easypost.com/docs/api#update-a-webhook">Related API documentation</a>.
         /// </summary>
-        /// <param name="parameters">Data to update <see cref="Webhook"/> with.</param>
         /// <param name="id">The ID of the <see cref="Webhook"/> to update.</param>
+        /// <param name="parameters">Optional data to update <see cref="Webhook"/> with.</param>
         /// <param name="cancellationToken"><see cref="CancellationToken"/> to use for the HTTP request.</param>
         /// <returns>The updated <see cref="Webhook"/>.</returns>
         [CrudOperations.Update]
-        public async Task<Webhook> Update(string id, Parameters.Webhook.Update parameters, CancellationToken cancellationToken = default)
+        public async Task<Webhook> Update(string id, Parameters.Webhook.Update? parameters = null, CancellationToken cancellationToken = default)
         {
-            return await RequestAsync<Webhook>(Method.Put, $"webhooks/{id}", cancellationToken, parameters.ToDictionary());
+            return await RequestAsync<Webhook>(Method.Put, $"webhooks/{id}", cancellationToken, parameters?.ToDictionary());
         }
 
         /// <summary>