Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong vertical camera centering offset by 8px on maps larger than 15 tiles height #361

Closed
gadesx opened this issue Nov 20, 2014 · 2 comments
Closed

Wrong vertical camera centering offset by 8px on maps larger than 15 tiles height #361

gadesx opened this issue Nov 20, 2014 · 2 comments
Labels
Patch available Testcase available

Comments

@gadesx
Copy link

gadesx commented Nov 20, 2014

Problem: All the game in easy rpg is like 8px below of the correct area,
so playing in window or fullscreen you will see 8px more in the up-part and
8px less below.
It seems that you can't see this problem in maps of 20x15

4

Test case, start in TEST Map size
http://dl.dropboxusercontent.com/u/22524283/temporal/Tests%20varios.rar
@Ghabry
Copy link
Member

Ghabry commented Nov 21, 2014

Hu?
The first time I noticed that was when I started developing map looping and thought this is a bug in my code.
How could we miss that o_O

@fdelapena fdelapena changed the title Size of the window area Wrong vertical camera centering offset by 8px on maps larger than 15 tiles height Nov 22, 2014
Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Nov 22, 2014
@Ghabry
Fix wrong camera offset. Fixes EasyRPG#361
c9cdd2d
@fdelapena fdelapena mentioned this issue Nov 22, 2014
Closed
@Ghabry Ghabry closed this as completed in 782c258 Nov 27, 2014
fdelapena added a commit that referenced this issue Nov 27, 2014
@fdelapena
Merge pull request #370 from fdelapena/master
72c0406 
Fix wrong camera offset. Fixes #361
@fdelapena
Copy link
Contributor

This was fixed already by @Zegeri at 74c660f and merged at #326 but for some reason this change got lost (bad file conflict resolution somewhere?). Both changes have been merged before 0.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Patch available Testcase available
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fdelapena @Ghabry @gadesx