-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Back button call menu in ButtonMapping Activities #511
Conversation
I remembered that in Player Activity, back button ask a confirmation to quit the game. Should I delete this behavior to call the menu too ?
|
Because some recent devices don't have hardware menu buttons (only home and back buttons), I think any hardware involved menu button should be removed. Adding an action bar for this and stealing space in the game screen is ugly so this feature could be added to the back button instead. A good device example without this button: HTC One. |
@fdelapena there is no hardware button involved in the android port :p . (My phone doesn't have such a button and I have no problem). But I think I'll associate the menu to back button to the Player Activity, because back button is already associated to a pop-up box (asking for stopping the game). |
Done ! |
Thanks for the fix. Just got back from a short weekend trip. Will check tomorrow :) |
Tested here, back button works for adding/editing from the screen button layout editor with latest pull request generated .apk 👍. |
Sorry that this took so long, was without internet the last days. |
Back button call menu in ButtonMapping Activities
One issue is still that the config function of the Game Browser is not obvious. |
These UX issues have been reported at #512 some days ago. |
No description provided.