Different bitmap fonts #1143

rohkea · 2017-04-15T16:50:33Z

This pull request:

Adds separate ‘official’ fonts and ‘unofficial’ fonts:
- Official fonts are Shinonome Mincho and Shinonome Gothic (they are only Japanese characters differ in those fonts). They are compatible with MS Mincho/Gothic (`this' is displayed like ‘this’). They are used when an engine is used with the default encoding (Japanese engine + Japanese encoding = official fonts).
- Unofficial fonts are RM2000 and RMG2000; they are compatible with Don Miguel’s fonts. They are used when an engine is used with a non-standard encoding (Japanese engine + Cyrillic encoding = unofficial fonts). RMG2000 is based on Shinonome’s existing font, RM2000 is edited to match Don Miguel’s RM2000.
Adds a possibility to change the font in the System graphics.

Here is a comparison of how this looks like:

The first row is Don Miguel’s translation, for comparison;
the second row is the new ‘unofficial’ fonts RM2000 and RMG2000;
the third row is the ‘official’ fonts Mincho and Gothic; unfortunately, the difference is not seen as only Japanese characters are different. Mincho can be edited to add serifs to Latin letters.

I’ve removed the font field from the Bitmap, and now pass font to text-drawing routines. This is neccessary because otherwise, the Font::Default() is only called once for every bitmap, when the bitmap is instantiated, and then it’s difficult to switch from Mincho to Gothic (from RMG2000 to RM2000).

Japanese fonts have a few quirks that don’t need to be reproduced in other languages. So, it makes sense to have separate Japanese fonts for official translations, and other fonts for unofficial translations. The major differences of Japanese fonts are: — ` (grave accent) is opening quote, — ' (straight apostrophe) is a closing quote, — " (straight double quote) is a closing double quote, — Cyrillic and Greek characters are double-width, — ellipsis is in the middle of the line (also useful for Chinese and maybe Korean). For RMG2000, a font similar to Shinonome is used (but without the peculiarities described above). For RM2000, a new font is added. Like Don Miguel's RM2000, it has different style for Cyrillic and Latin, Cyrillic is bigger than Latin. For Cyrillic, I've used a 'straight italic' style (so-called Bulgarian cyrillic). Its look-and-feel is similar to Don's RM2000 font.

It's in the bottom of the line, and halfwidth.

I will need to overload them to accept a font argument, effectively doubling the number of functions. So, to get the complexity under control, I’ve removed some overloads that accept x, y, width, height because the functions with rect do the same thing.

I've decided against overloading TextDraw to allow calling it without font because this function is already overloaded too much. Instead, I've made font a required argument, and added calls to Font::Default() in the places where TextDraw is called.

rohkea · 2017-04-18T22:53:25Z

I’ve replaced the RM2000-compatible font with ttyp0, as suggested in chat. The left screenshot now looks like this (the right one hasn’t changed, attaching it for completeness):

The best thing about ttyp0 is its wide coverage of scripts. We just got support for Georgian, Armenian and Greek without doing anything. Here’s the first stanza from Sappho’s Hymn to Aphrodite:

Ghabry · 2017-04-22T01:34:14Z

Please check your whitespace, is partly space instead of tab.

About TextDraw: Because you pass Font::Default() everywhere anyway how about simply hardcoding the font to Font::Default() in TextDraw instead of adding a FontRef argument?

The original idea behind using Japanese fonts for the official English release was that it used MS Mincho/MS Gothic. However, upon closer inspection I've noticed that the official releases use EDITED MS Mincho and MS Gothic (in the official RM2kE, they are called RPG2000 and RPG2000G), and those edited fonts use a European … and not Japanese). So, I think it’s safe to lump them alongside with the unofficial translations and use ttyp0 for them.

rohkea · 2017-04-22T10:21:17Z

Please check your whitespace, is partly space instead of tab.

Sorry! I’ve changed by vim settings so this shouldn’t happen again.

The whitespace was in the function for checking if Engine is an official release. I think this function is not needed. I’ve noticed that the official English release doesn’t use the same font as Japanese release (e.g. … is European, not Japanese in RPG2k3E), so I think it makes sense to use ttyp0/RMG2000 for RPG2k3E too, in the same way as for Don’s translation.

About TextDraw: Because you pass Font::Default() everywhere anyway how about simply hardcoding the font to Font::Default() in TextDraw instead of adding a FontRef argument?

Yes, I can do this. I don’t think anyone relies on the ability to change the font.

Our current naming became confusing when we added other fonts (WenQuanYi, ttyp0). They are not Shinonome, and they are kept as separate entities, but they were still referenced as Shinonome in the code.

rohkea · 2017-04-22T13:23:20Z

resources/wenquanyi/README

@@ -20,20 +20,22 @@ from wqy-bitmapsong-bdf-1.0.0-RC1.tar.gz
 wenquanyi_cjk_basic_9pt.bdf
 GPLv2+FE

+is generated by the following coommand:


I've added this change to make the English text correspond to the Chinese text below.

Ghabry · 2017-04-22T15:11:07Z

Font comparison: And picture 2 has a problem with missing glyphs.

Ghabry · 2017-04-22T17:54:43Z

rohkea · 2017-04-22T18:20:55Z

Thanks for noticing the problems! I’ve fixed the problem Shinonome Mincho not falling back on Shinonome Gothic:

kakurasan · 2017-04-23T03:23:31Z

The "displayed in Mincho" behavior seems unexpected.

histoire / RPG_RT on Japanese Windows (Gothic):

histoire / Player 0.5.1 (Gothic):

histoire / patched (Mincho):

Yume Nikki / RPG_RT on Japanese Windows (Gothic):

Yume Nikki / Player 0.5.1 (Gothic):

Also note that lots of "glyph not found:" messages are displayed in Japanese games.

rohkea · 2017-04-23T06:21:37Z

@kakurasan Thank you very much for the testing, I wouldn’t have found this myself!

The "displayed in Mincho" behavior seems unexpected.

Look like I’ve swapped Mincho and Gothic by accident! I’ll fix this in less than an hour.

Also note that lots of "glyph not found:" messages are displayed in Japanese games.

Thanks for noticing! Shinomome Mincho doesn’t contain all the characters and is expected to fallback on Shinonome Gothic, so those messages are not useful. I’ll change the code so that the messages are only shown if a glyph is missing in all the fonts, not just in the first font.

I’ll update my pull request in less than an hour.

If the glyph is not found in just one font, but is found in another (e.g. not found in Mincho, but found in Gothic), this is not something that needs reporting. Also, moving the <?> handling into find_fallback_glyph makes other glyph-finding functions cleaner since they only need to check for NULL.

rohkea · 2017-04-23T07:43:46Z

I’ve swapped Gothic with Mincho for Japanese games, the codes are now like this:

Gothic=ID 0 in Japanese games (might need to add it for Chinese and Korean, since they also use … in the middle of the line, but I don’t know how to check for Chinese and Korean),
Mincho=ID 1 in Japanese games (might need to add it for Chinese and Korean),
ttyp0=ID 0 in non-Japanese games,
RMG2000 (Latin from Shinonome with minor edits)= ID 1 in non-Japanese games.

And I’ve changed the error reporting: now the error is only displayed when all the fonts lack a glyph, not when just one font lacks a glyph.

Yume Nikki is now displayed in Gothic, again. ~~I didn’t have a chance to test histoire yet.~~ Updated: checked histoire, it uses Gothic now, too.

Ghabry · 2017-04-24T14:17:13Z

Somehow the font switching doesn't work for me. I always get that new, small font. I assumed that RMG2000 should still give Shinonome? And isn't RMG2000 ID=0?

Based on RPG2k:

RMG2000
RM2000 (by Don)
my diff says:

⋊> ~/Spiel/RPG M/OFF diff RPG_RT_RM2000.xml RPG_RT_RMG2000.xml
133947c133947
<     <font_id>1</font_id>
---
>     <font_id>0</font_id>

About detecting other languages, see Player::IsCP932.

The checks for korean would be: "windows-949-2000" (or "949") and for chinese: "windows-936-2000" and "936". For traditional chinese I don't have a game floating around. Simply run it and check what "Detected encoding:" shows.

Ghabry · 2017-04-24T14:27:27Z

Further tests: Setting the font in the database doesn't work at all. I always get that new small font (RM2000?).

And in tests I get this: Shouldnt it be inverted?

rohkea · 2017-04-24T14:40:13Z

And isn't RMG2000 ID=0?

I think there is an error in Don’s RM2k translation. The Editor says that RMG2000 is 0, RM2000 is 1. However, the RPG_RT displays RM2000 for 0, RMG2000 for 1. This pull request matches the behaviour of the Player, so it gives ttyp0 as ID 0, RMG2000 (=edited Shinonome) for ID 1.

This is also consistent with the official RPG Maker 2000 release, which uses RPG2000 (serif font) for ID 0, RPG2000G (sans-serif font) for ID 1.

I can swap them if you want, as there are little consistency between the versions: some RPG_RT translations assign IDs to RM2000 and RMG2000 differently.

And in tests I get this: Shouldnt it be inverted?

Maybe? I’m following Don’s RPG_RT (not editor) and the official English RPG Maker 2000 release. Some other releases seem to assign font IDs differently. It depends on what we should consider a reference.

Further tests: Setting the font in the database doesn't work at all.

Indeed, I can confirm this bug. Thanks for noticing! I’ll fix it.

Ghabry

The code itself looks fine to me. I just need some extra testing time to find sense in the chaos of RPG Maker.

rohkea · 2017-04-24T20:21:07Z

Just as a showcase of Armenian support in ttyp0, here’s an extract from a poem Like Wild Lilies by Hovhannes Shiraz:

I’ve used lcf2xml to add Armenian text because EasyRPG editor is not finished yet, and RPG Maker 2000/2003 doesn’t support Armenian.

carstene1ns · 2017-05-06T21:17:56Z

Btw. this increases our executable size by ~100 kb.

rohkea · 2017-05-06T21:49:10Z

This pull request adds 470 characters in BITMAPFONT_RMG2000 and 3074 characters in BITMAPFONT_TTYP0.

If the size is important, we can reduce the size this way:

In BITMAPFONT_WQY, remove characters that are covered by SHINONOME_GOTHIC. Since WenQuanYi is only used as a fallback, those characters are never displayed. This can decrease the character count by ~7000.
In BITMAPFONT_RMG2000, only keep the characters that are different from SHINONOME_GOTHIC (i.e. Cyrillic and punctuation). Since BITMAPFONT_RMG2000 was partly copied from SHINONOME_GOTHIC, it has overlaps. This can reduce the character count by ~200.

The following changes could be visible to the user:

Remove fullwidth Cyrillic from SHINONOME_GOTHIC and use narrow Cyrillic BITMAPFONT_RMG2000 instead. This is not compatible with MS Mincho/Gothic, but I doubt any Japanese game depends on Cyrillic being fullwidth. In fact, I doubt any Japanese game uses Cyrillic.
Remove some scripts from ttyp0. The obvious candidates are Thai and Hebrew, because those scripts are not currently supported (no RTL support for Hebrew, no diacritic placement for Thai).

I think removing unused characters from WenQuanYi seems the best way to reduce the font size. It could also be nice to merge shinonome/generate_cxx_font.rb and wenquanyi/gen_wqy_font_cpp.py into one script, since they basically do the same thing.

Ghabry · 2017-05-07T00:08:35Z

Finally found some time to test games under Windows for visual comparison. That ttyp0 font matches quite closely to the RPG_RT font but the RPG_RT font is waaaay uglier (completely forgot about this, too much used to EasyRPG fonts) :D

carstene1ns · 2017-05-07T08:57:54Z

Yeah, same here. I do not really like the r in ttyp0, but I guess that is just nitpicking.

Different bitmap fonts

rohkea added 7 commits April 15, 2017 04:05

Add RM2000-compatible ellipsis (0x2026)

076d354

It's in the bottom of the line, and halfwidth.

Code style: spaces converted to tabs

7dee130

Allow switching between Mincho/Gothic (RM2000/RMG2000)

0f30da5

Fix Emscripten and Windows build

36f9af7

carstene1ns mentioned this pull request Apr 17, 2017

Support serif fonts when MS Mincho is selected in database or in game from command #352

Closed

carstene1ns added this to the 0.5.2 milestone Apr 17, 2017

carstene1ns added the Refactor label Apr 17, 2017

carstene1ns requested a review from Ghabry April 17, 2017 10:04

rohkea added 2 commits April 19, 2017 01:38

Use ttyp0 instead of RM2000

cd7f92d

Add generated cpp file into git too

68d147d

rohkea added 2 commits April 22, 2017 14:35

Rename Shinonome to BitmapFont

4a96d46

Our current naming became confusing when we added other fonts (WenQuanYi, ttyp0). They are not Shinonome, and they are kept as separate entities, but they were still referenced as Shinonome in the code.

Hardcode Font::Default into Bitmap::TextDraw

8f9521f

rohkea commented Apr 22, 2017

View reviewed changes

Keep comments up-to-date

e5e4568

rohkea added 2 commits April 22, 2017 21:16

Fix missing glyphs in Mincho (for Japanese games)

020f03b

Fix typo in comments about regenerating WenQuanYi

515e40b

fdelapena approved these changes Apr 22, 2017

View reviewed changes

Use Gothic=0 Mincho=1 ttyp0=0 RMG2000=1

a0c8f19

Ghabry reviewed Apr 24, 2017

View reviewed changes

rohkea mentioned this pull request Apr 24, 2017

Initialise font_id EasyRPG/liblcf#200

Merged

carstene1ns approved these changes Apr 24, 2017

View reviewed changes

Use Shinonome Gothic/Mincho for Korean and Chinese, too

69b7ba1

rohkea closed this May 6, 2017

rohkea reopened this May 6, 2017

Ghabry approved these changes May 7, 2017

View reviewed changes

carstene1ns merged commit 13ec38a into EasyRPG:master May 7, 2017

rohkea deleted the different_fonts branch May 8, 2017 09:27

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this pull request May 22, 2018

Merge pull request EasyRPG#1143 from rohkea/different_fonts

5b11739

Different bitmap fonts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Different bitmap fonts #1143

Different bitmap fonts #1143

rohkea commented Apr 15, 2017 •

edited

Loading

rohkea commented Apr 18, 2017 •

edited

Loading

Ghabry commented Apr 22, 2017

rohkea commented Apr 22, 2017 •

edited

Loading

rohkea Apr 22, 2017

carstene1ns Apr 22, 2017

Ghabry commented Apr 22, 2017

Ghabry commented Apr 22, 2017

rohkea commented Apr 22, 2017

kakurasan commented Apr 23, 2017

rohkea commented Apr 23, 2017 •

edited

Loading

rohkea commented Apr 23, 2017 •

edited

Loading

Ghabry commented Apr 24, 2017 •

edited

Loading

Ghabry commented Apr 24, 2017

rohkea commented Apr 24, 2017 •

edited

Loading

Ghabry left a comment •

edited

Loading

rohkea commented Apr 24, 2017 •

edited

Loading

carstene1ns commented May 6, 2017

rohkea commented May 6, 2017 •

edited

Loading

Ghabry commented May 7, 2017

carstene1ns commented May 7, 2017

Different bitmap fonts #1143

Different bitmap fonts #1143

Conversation

rohkea commented Apr 15, 2017 • edited Loading

rohkea commented Apr 18, 2017 • edited Loading

Ghabry commented Apr 22, 2017

rohkea commented Apr 22, 2017 • edited Loading

rohkea Apr 22, 2017

Choose a reason for hiding this comment

carstene1ns Apr 22, 2017

Choose a reason for hiding this comment

Ghabry commented Apr 22, 2017

Ghabry commented Apr 22, 2017

rohkea commented Apr 22, 2017

kakurasan commented Apr 23, 2017

rohkea commented Apr 23, 2017 • edited Loading

rohkea commented Apr 23, 2017 • edited Loading

Ghabry commented Apr 24, 2017 • edited Loading

Ghabry commented Apr 24, 2017

rohkea commented Apr 24, 2017 • edited Loading

Ghabry left a comment • edited Loading

Choose a reason for hiding this comment

rohkea commented Apr 24, 2017 • edited Loading

carstene1ns commented May 6, 2017

rohkea commented May 6, 2017 • edited Loading

Ghabry commented May 7, 2017

carstene1ns commented May 7, 2017

rohkea commented Apr 15, 2017 •

edited

Loading

rohkea commented Apr 18, 2017 •

edited

Loading

rohkea commented Apr 22, 2017 •

edited

Loading

rohkea commented Apr 23, 2017 •

edited

Loading

rohkea commented Apr 23, 2017 •

edited

Loading

Ghabry commented Apr 24, 2017 •

edited

Loading

rohkea commented Apr 24, 2017 •

edited

Loading

Ghabry left a comment •

edited

Loading

rohkea commented Apr 24, 2017 •

edited

Loading

rohkea commented May 6, 2017 •

edited

Loading