Redirect Teleport and Escape skills that target areas to the owning map #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstene1ns
reviewed
Aug 23, 2017
src/game_player.cpp
Outdated
| ReserveTeleport(target.map_id, target.map_x, target.map_y, Down); | ||
| int map_id = target.map_id; | ||
|
|
||
| if (Game_Map::GetMapType(target.map_id) == 2) { |
There was a problem hiding this comment.
We really need some enums/constants for such things.
There was a problem hiding this comment.
I agree on this, but the build will fail now ;)
…and teleport to the parent map instead. The only games affected by this are the two japanese Dragon Quest fangames DQ列伝 and DQ2悪霊の勇者・製品版 Fix EasyRPG#1253
carstene1ns
approved these changes
Aug 23, 2017
|
jenkins: test this please |
fdelapena
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only games affected by this are the two japanese Dragon Quest fangames DQ列伝 and DQ2悪霊の勇者・製品版
Fix #1253
The two new functions in Game_Map could be used in some other places, too but I'm too afraid to break something...