Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Albeleons's Battle fixes 1 of N #1447
Here is the first batch of rebased fixes from #1373
All of these are pretty simple changes so I'm making a first PR with these. They are not all in the same order as originally presented. I'm trying to pull out the ones that are simple and don't require a lot of merging so they can be quickly reviewed and merged into master.
3 times, most recently
Oct 15, 2018
2.7: I remember there were some complications with the "\" and "Player::escapeChar" after trying to change the codification from Occidental to Japanese that made me go back to "\" again. I'll put a pin on this and recheck comparing both again.
4,1: The reason why PlayBGM was kept twice is because the battle music should sound also when you only do a battle test (without opening the map), and it doesn't reach Scene_Map::CallBattle in that case. I considered there was no problem with a double call because the function PlayBGM doesn't take much workaround if the song is the same with the same conditions. But this is up to discussion.
2.15: I don't remember why I took out "const", maybe it was during tests trying things to make it work and I just kept it, or there was a definition problem? I don't remember ^^u, I hope it was just a mistake for my part, but just in case later I'll recheck that commit to see whether there is a difference or not.
@Albeleon why don't you take these over again? You have a much better understanding of your changes than me.
I can close out my PRs
EDIT: I've left 1, and 2 of my set open. Up to you how you'd like to proceed but if you need help merging this with your other big PR's I can at least continue with these.
Reverted 2.7 and 4.1
I have no idea what the original problem was but replacing "\\" with Player::escape_symbol works for me.
You can use encoding "ibm-943_P130-1999" (Japanese with Yen as backslash) for testing.
Possible this and #1394 can merged this weekend? Of all the PRs out there Sormats are the most important in my opinion.
They are large and likely will introduce regressions. We will need time after merging everything to test the new master before the next release.