Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case with map save/escape/teleport flags #1597

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@fmatthew5876
Copy link
Contributor

fmatthew5876 commented Jan 3, 2019

Create a map as a child of another map. Set its save,
escape, and teleport flags to 0 (parent). Now move
this map to the root. The flags will remain 0 but the
actions will be enabled by RPG_RT as there is no parent map.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:map_fix branch 3 times, most recently from e5b1e46 to 74715c3 Jan 3, 2019

Fix edge case with map save/escape/teleport flags
Create a map as a child of another map. Set its save,
escape, and teleport flags to 0 (parent). Now move
this map to the root. The flags will remain 0 but the
actions will be enabled by RPG_RT as there is no parent map.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:map_fix branch from 74715c3 to 1d43c02 Jan 3, 2019

@carstene1ns
Copy link
Member

carstene1ns left a comment

Ugly corner case and really an editor bug IMHO.

@Ghabry Ghabry added this to the 0.6.0 (likely) milestone Jan 3, 2019

@Ghabry

Ghabry approved these changes Jan 3, 2019

@Ghabry Ghabry merged commit 811722b into EasyRPG:master Jan 3, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details

@fmatthew5876 fmatthew5876 deleted the fmatthew5876:map_fix branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.