Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support for SetVehicleLocation() teleport.. #1782

Merged
merged 4 commits into from
Aug 4, 2019
Merged

Improved support for SetVehicleLocation() teleport.. #1782

merged 4 commits into from
Aug 4, 2019

Conversation

fmatthew5876
Copy link
Contributor

@fmatthew5876 fmatthew5876 commented May 29, 2019 •
edited by Ghabry
Loading

Fix: #1778

Depends on: #1740

Test case 4 requires #1779

@fmatthew5876 fmatthew5876 force-pushed the vehicle_teleport branch 2 times, most recently from 0963713 to c61e439 Compare May 29, 2019 03:25
@fmatthew5876
Copy link
Contributor Author

fmatthew5876 commented May 29, 2019 •
edited
Loading

This is tested and ready for review.

@fmatthew5876 fmatthew5876 mentioned this pull request May 29, 2019
Merged
@fmatthew5876 fmatthew5876 force-pushed the vehicle_teleport branch 2 times, most recently from 0d0beee to 4ef25d1 Compare May 29, 2019 04:12
@Ghabry Ghabry added this to the 0.6.2 milestone May 29, 2019
Ghabry
Ghabry approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for all commits starting from

Improve support for SetVehicleLocation() teleports

Everything works perfectly in Yume2kki Music scene.

Maybe there could be debug output when SetVehicle is used for cross-map teleport?

@fmatthew5876 fmatthew5876 force-pushed the vehicle_teleport branch 2 times, most recently from d25e0e2 to 4b85e5d Compare June 9, 2019 13:53
@Ghabry Ghabry added the Awaiting Rebase Pull requests with conflicting files due to former merge label Aug 4, 2019
@Ghabry
Copy link
Member

Ghabry commented Aug 4, 2019

@fdelapena
I already approved this weeks ago, after rebasing you can merge it, thx!

@fmatthew5876
Copy link
Contributor Author

rebased to master

@fdelapena fdelapena merged commit fbd7bcd into EasyRPG:master Aug 4, 2019
@fmatthew5876 fmatthew5876 deleted the vehicle_teleport branch January 16, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Ghabry approved these changes

Assignees
No one assigned
Labels
Awaiting Rebase Pull requests with conflicting files due to former merge Event/Interpreter
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Yume2kki: Music room broken, reports "Unknown Event 10005"
3 participants
@fmatthew5876 @Ghabry @fdelapena