Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Stepping +/- HP/SP states fixes #1805

Merged
merged 4 commits into from
Jun 9, 2019
Merged

Map Stepping +/- HP/SP states fixes #1805

merged 4 commits into from
Jun 9, 2019

Conversation

fmatthew5876
Copy link
Contributor

@fmatthew5876 fmatthew5876 commented Jun 8, 2019 •
edited
Loading

Fix: #1804
Fix: #1806

@Ghabry Ghabry added this to the 0.6.1 milestone Jun 8, 2019
Ghabry
Ghabry approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
2nd if could use elseif.

@fmatthew5876
Copy link
Contributor Author

Changed it to else if

@fmatthew5876
Implement map movement increases hp/sp
affcb99 
Fix: EasyRPG#1804
@fmatthew5876
Disable continuous flash on Flash Once
1084999 
- Fixes continuous flash followed by flash once commannd
- Fixes continuous flash interupted by other effects like
  red flash due to poison
@fmatthew5876
Add Game_Screen::FlashMapStepDamage
f442f9e 
- Abstract stepping flash effect
- Use correct paramters (taken from save games test)
@fmatthew5876
Don't apply state hp effects on move routes
da62acf
@fmatthew5876
Copy link
Contributor Author

I added some more commits to fix #1806

@fmatthew5876 fmatthew5876 changed the title Implement map movement increases hp/sp Map Stepping +/- HP/SP states fixes Jun 8, 2019
@Ghabry Ghabry merged commit 0a020c8 into EasyRPG:master Jun 9, 2019
@fmatthew5876 fmatthew5876 deleted the heal_steps branch January 16, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Ghabry approved these changes

@carstene1ns carstene1ns carstene1ns approved these changes

Assignees
No one assigned
Labels
Event/Interpreter
Milestone
0.6.1
4 participants
@fmatthew5876 @fdelapena @Ghabry @carstene1ns