Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Stepping +/- HP/SP states fixes #1805

Merged
merged 4 commits into from Jun 9, 2019

Conversation

@fmatthew5876
Copy link
Contributor

commented Jun 8, 2019

Fix: #1804
Fix: #1806

@Ghabry Ghabry added this to the 0.6.1 milestone Jun 8, 2019

@Ghabry

Ghabry approved these changes Jun 8, 2019

Copy link
Member

left a comment

LGTM.
2nd if could use elseif.

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:heal_steps branch from 50f8ac4 to 8010350 Jun 8, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Changed it to else if

fmatthew5876 added some commits Jun 8, 2019

Disable continuous flash on Flash Once
- Fixes continuous flash followed by flash once commannd
- Fixes continuous flash interupted by other effects like
  red flash due to poison
Add Game_Screen::FlashMapStepDamage
- Abstract stepping flash effect
- Use correct paramters (taken from save games test)

@fmatthew5876 fmatthew5876 force-pushed the fmatthew5876:heal_steps branch from 8010350 to da62acf Jun 8, 2019

@fmatthew5876

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

I added some more commits to fix #1806

@fmatthew5876 fmatthew5876 changed the title Implement map movement increases hp/sp Map Stepping +/- HP/SP states fixes Jun 8, 2019

@Ghabry Ghabry merged commit 0a020c8 into EasyRPG:master Jun 9, 2019

7 checks passed

Android (armeabi-v7a) Build finished.
Details
GNU/Linux Build finished.
Details
OSX Build finished.
Details
Wii (SDL1) Build finished.
Details
Windows (x64) Build finished.
Details
Windows (x86) Build finished.
Details
web Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.