Refactor Interpreter Stack Frame Completion #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmatthew5876
force-pushed
the
event_stack
branch
from
c2c9678
to
70410b4
Compare
fdelapena
added
the
Performance
fmatthew5876
force-pushed
the
event_stack
branch
3 times, most recently
from
0ed1841
to
79b6ab0
Compare
fdelapena
approved these changes
Aug 29, 2019
This was referenced Aug 30, 2019
fmatthew5876
force-pushed
the
event_stack
branch
from
79b6ab0
to
b678a1e
Compare
|
Rebased and added a very minor optimization when we check if parallel event can execute. |
carstene1ns
approved these changes
Sep 2, 2019
fmatthew5876
force-pushed
the
event_stack
branch
from
b678a1e
to
f073dae
Compare
* Rename CommandEnd() to OnFinishStackFrame() This name and it's nearby comment was very misleading. The interpreter has actually always ignored CommandEnd commands. This function was only called when the index ran past end of the stack frame. * Do OnFinishStackFrame() before execution loop. Call this in one place and handle multiple stack pops. Also, don't hang on empty events. * Optimize parallel events Reset the index and never pop the base stack frame. RPG_RT does this and we avoid copying parallel event data every frame.
RPG_RT save games always have an empty base stack frame allocated for parallel map events and common events. We add these to our saves to be compatible, however if we have empty data, we won't create an interpreter object or load any data.
fmatthew5876
force-pushed
the
event_stack
branch
from
f073dae
to
0c54f4d
Compare
This was referenced Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1871
This should also fix: #1764 once we solve #1883
Supercedes #1879 If we merge this we don't need that one.
This name and it's nearby comment was very misleading. The
interpreter has actually always ignored
CommandEndcommands.This function was only called when the index ran past end of the stack
frame.
Call this in one place and handle multiple stack pops. Also,
don't hang on empty events.
Reset the index and never pop the base stack frame. RPG_RT
does this and we avoid copying parallel event data every frame.
RPG_RT will always create a stack frame for parallel events,
even if they are empty.