Regression fixes #2177
Merged
Regression fixes #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t directory. The FileFinder data structure stores files in the root dir at a different location, call into FindDefault to solve this. Fix EasyRPG#2176 Regression caused by 7de54b6
fdelapena
approved these changes
Apr 28, 2020
|
Added a small fix here to address Android 10 & 12 if you don't mind. Though I'm still curious which game causes this. :/ The magic is reported in platform byte order. As this is only error path didn't care to fix this. |
…age file has an unsupported magic number. Fix memleak when creating a Bitmap of a raw buffer fails (unlikely, all this data is app controlled) This is Android crash 10 & 12
fmatthew5876
approved these changes
Apr 28, 2020
Ghabry
changed the title
…is used in 2k3<1.10 the top_trans must be copied into bottom_trans. Regression caused by 1b6b7d9 Fix EasyRPG#2178
|
Renamed this to "Regression fixes" now. |
fmatthew5876
approved these changes
Apr 29, 2020
|
I would like to pull this one in the maintenance branch. |
carstene1ns
approved these changes
Apr 30, 2020
|
There is a bug report mail about bad images in VD2 intro: Is fixed my the ShowPicture fix |
carstene1ns
added
the
backport to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a flaw (well, the structure made sense because there is no way to read stuff from ./, but then "creative" games appeared...) with the FileFinder data structure: The root-directory files are stored in a different location than the submembers, so there must be extra handling for finding files in the root-dir.
Fix #2176
Regression caused by 7de54b6