Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diagonal moves and fix some movement-related issues #224

Merged
merged 10 commits into from
May 30, 2014

Conversation

Zegeri
Copy link
Member

@Zegeri Zegeri commented May 29, 2014

Other notes:

  • In vertical/horizontal move cycles, the character waits now a bit each time it reverses its direction.
  • The move frequency is now more accurate, but it's still not frame-perfect.
  • You can no longer walk through Ib's parents at the start of the game.

@Ghabry Ghabry added this to the 0.2 milestone May 29, 2014
@Ghabry
Copy link
Member

Ghabry commented May 29, 2014

Compiling fails because of ambigious arguments to the pow-function:

2>..\..\src\game_character.cpp(201): error C2668: 'pow': Mehrdeutiger Aufruf einer überladenen Funktion
2>          D:\Programme\Microsoft Visual Studio 10.0\VC\include\math.h(583): kann 'long double pow(long double,int)' sein
2>          D:\Programme\Microsoft Visual Studio 10.0\VC\include\math.h(535): oder "float pow(float,int)"
2>          D:\Programme\Microsoft Visual Studio 10.0\VC\include\math.h(497): oder "double pow(double,int)"
2>          bei Anpassung der Argumentliste '(int, int)'

@Zegeri
Copy link
Member Author

Zegeri commented May 30, 2014

Could you check if it compiles now well in Visual Studio?

@Ghabry
Copy link
Member

Ghabry commented May 30, 2014

will check when I'm home at my laptop

Avoid using uninitialized data. Call MoveTypeCustom after the event has
been pushed back in the pending vector. After the last move, end move
routes as soon as the characters stop moving.
@Zegeri
Copy link
Member Author

Zegeri commented May 30, 2014

I'm rewriting some history to remove my fix of issue #146. Ghabry's 71a6e1d is better.

@Ghabry
Copy link
Member

Ghabry commented May 30, 2014

Compiles fine now. Testing...

Ghabry added a commit that referenced this pull request May 30, 2014
Implement diagonal moves and fix some movement-related issues
@Ghabry Ghabry merged commit 847c00a into EasyRPG:master May 30, 2014
@Zegeri Zegeri deleted the movements branch May 31, 2014 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants