-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport emscripten-core/emscripten#7631 for focus on iframes #2307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine but can't be tested right now because of EasyRPG/buildscripts#83
Multiple games on sites like rmarchiv itch.io and similar will benefit on this. Additinally, remove the default 'Downloading...' text to prevent user confusion when robots shows web content preview.
This is ready. Tested with Firefox and Chromium, automatic canvas resizing on windowed mode seems to work, though full screen toggle goes black for some (likely unrelated) reason. |
Imo removing downloading is not the way to go. You could call it "Loading game..." and then use open graph standard to get a better link preview. |
The "Downloading..." is set just later from JavaScript, so the experience doesn't change in practice. It could even contain a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how but your media queries (?) broke the fullscreen function.
You could also try with Module.requestFullscreen
I replaced this with Module['canvas'].requestFullscreen because the emscripten solution was broken (it works by wrapping the canvas in a div and requesting fullscreen from the div)
There is this
|
Multiple games on sites like rmarchiv itch.io and similar will benefit on this.
Additinally, remove the default 'Downloading...' text to prevent user confusion when robots show web content preview.
Closes: #804.