Proper overflow handling #2734
Merged
Proper overflow handling #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
fdelapena
approved these changes
Feb 24, 2022
|
Undefined behaviour at its finest and only in release: Changed to long long to ensure it fits ^^ |
fdelapena
approved these changes
Feb 28, 2022
fdelapena
added
the
Awaiting Rebase
Ghabry
removed
the
Awaiting Rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When variables overflow the value is now correctly clamped.
Mostly required by Maniac Patch because it uses the entire integer range but also broke with multiply in normal maker (see fixed issue).
Also implemented the "Input numbers via numpad" extension from newer Maniac versions.
Fix #2650