-
Notifications
You must be signed in to change notification settings - Fork 197
VITA: add ability to invoke app with game path provided via boot parameter #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cy33hc So the |
Thx @Ghabry for reviewing. I also found the commit #8de4c7d3344f82449d61e6b7ac505cc3e6cbe6eb broke the psvita build. I spent an hour building backward and found this commit. |
@cy33hc I also found an additional issue causing the breakage: We built vita2dlib on our buildbot incorrectly. So in a few days everything should run again :D |
What he meant was that our official build is broken in 2 ways. 😅 |
Yeah but Vita3k only cares about the vita2dlib one. I cannot revert the commit because empty string is actually used for the working directory (converted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me.
Any improvements to the parser can land in #2781
@cy33hc Could you test if the latest source from And please compile yourself, our buildbot-version is still broken. :) |
@Ghabry Compiled from master and it is still crashing on startup. How to enable debug and where does the file get created?. I can try do a debug build to grab the logs. |
@cy33hc Thanks for the offer to help. Please update master again. Now everything should be in that was related to Vita (except your PR). A debug build is not really needed. The logging also works in Release. Then here https://github.com/EasyRPG/Player/blob/master/src/directory_tree.cpp#L26 Remove the comment before Then the error logging will be much more verbose. If the logfile is not being created (should appear in Change this e.g. to |
@Ghabry It's fails to compile now. Getting the following error message. It seems like the vita2dlib has some hardcoded references to the shaders that were removed. libvita2d/source/vita2d.c:362: undefined reference to `opaque_v' |
You need upstream libvita2d, not fbo-patched version. |
@Ghabry Great. I recompile from master with libvita2d lib and no more crashes. |
src/main_data.cpp
Outdated
// Check if app is invoked with an externalized game path | ||
char boot_params[1024]; | ||
sceAppMgrGetAppParam(boot_params); | ||
if (strstr(boot_params,"psgm:play") && strstr(boot_params, "&project_path=")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing, please use 'project-path' (with hyphen) for consistency with our official arguments.
…meter update project_path to project-path for consistency
@Ghabry @carstene1ns Updated project_path to project-path. |
Thank you! :) |
I'm the author of the Vita homebrew app called Vita-Launcher (https://github.com/cy33hc/vita-launcher). I want to add support for booting EastRPG games directly from my app. This requires some changes in EasyRPG to read the boot params passed from my app to start the game.
Let me know if you have any questions.
And before my change, the psvita build is crashing on startup. 0.7.0-stable is working fine.