Android : Fix the SDK compatibility of the Button Mapping System #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some // API11: KeyEvent.KEYCODE_NUMPAD_ADD comments like we do in other places? To prevent such merge commits you can use "rebase" instead. |
|
Huhu to be honest I use the Github app |
Ghabry
added a commit
that referenced
this pull request
Mar 24, 2015
Android : Fix the SDK compatibility of the Button Mapping System
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Ghabry, I used directly the value of keycode. I tested on a test project : everything is alright.