Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android : Fix the SDK compatibility of the Button Mapping System #443

Merged
merged 3 commits into from Mar 24, 2015

Conversation

@BlisterB
Copy link
Member

@BlisterB BlisterB commented Mar 24, 2015

As suggested by Ghabry, I used directly the value of keycode. I tested on a test project : everything is alright.

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 24, 2015

Can you add some // API11: KeyEvent.KEYCODE_NUMPAD_ADD comments like we do in other places?

To prevent such merge commits you can use "rebase" instead.

@BlisterB
Copy link
Member Author

@BlisterB BlisterB commented Mar 24, 2015

Huhu to be honest I use the Github app

Ghabry added a commit that referenced this pull request Mar 24, 2015
Android : Fix the SDK compatibility of the Button Mapping System
@Ghabry Ghabry merged commit e6ab92d into EasyRPG:master Mar 24, 2015
1 check passed
1 check passed
@fdelapena
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants