Fix pan speed and larger than 320x240 panoramas #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"horizontal/vertical pan" option
Ghabry
added a commit
that referenced
this pull request
Apr 28, 2015
Fix pan speed and larger than 320x240 panoramas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panoramas that
scroll in a very special manner. It chooses a parallax scroll speed such that it'll show the entire panorama when crossing the map, but never faster than 16 pixels per step. For this reason, we have to delay the panorama initialization until we know the image size (in spriteset_map.cpp).
These two commits should fix the opening of Link's Awakening (the RM2k3 port).
It seems that in RPG_RT if a looping maps has a large enough panorama, it isn't aligned with the top left corner. However, I won't have time in the next couple weeks to fix that.