Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Conditions in Battles #815
One reason speaking against ::Apply is that under RPG2k3 all actors get damage at the begin of a battle action (doesn't matter if ally or enemy). With Apply only the current one doing the action gets damage.
I suggest moving this to a function in Game_Battler and when invoking that function it directly alters SP and MP of that Battler.
For RPG2k you can place the call in ... maybe BattleActionState_ConditionHeal (for the FirstAttack case)
So for RPG2k3 I suggest placing the call to this function (and displaying the damage number (for HP only!) as a floating number) in the BattleActionState_Start for the "IsFirstAttack" case.
The RPG2k3 battle system also shows that damaging due to states happens before the action is executed.
The delay is still wrong here.
Normal attacks without any states have a 30 frame delay before anything happens -> Must be 0.
And after battle animations the feedback is now instant instead of a delay. (After showing the attack animation, e.g. the sword slash, the old version had a 30 frame delay).
And sometimes enemy attacks give me now a negative amount and heal me :O
Jenkins: Test this please