Fix some rare bugs #860
Merged
Fix some rare bugs #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the event to be in ghost mode after a new page is set up.
Push the move routes methods down in the Game_Event class. If an event can't do a step, it won't turn to the direction of the failed step. This is done to make the movement look more natural. In MoveTypeRandom: After using a dynrpg plugin to print the values of stepFrameCounter (in liblcf: stop_count) and frequencyTimer (in liblcf:max_stop_count), I've simulated the randomness of these two variables. After about 1000 steps, 38% of the steps were forward steps in RPG_RT, while 70% in Player. This has been reduced to 40% in Player.
|
This looks good enough for a quick merge 😀. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
導かれし者達(Nobisen: Path of the Chosen? I haven't found a translation of the title)