Add missing toString methods in selection classes #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not working as before anymore. Instead set the key focus manually.
adangel
added a commit
that referenced
this pull request
Apr 7, 2022
Add missing toString methods in selection classes
|
The commit Not using pushModal broke the extension for gnome 3.38 probably, see issue #333. Hopefully we can find a fix that works in 3.38 and newer gnome versions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the signal methods from GObject, but this didn't work out at all. So I kept the old
Signals.addSignalMethodssolution.After that, the extension loaded, but no area could be selected. It has something to do with
Main.pushModalwhich doesn't behave the same with gnome shell 42 anymore.