Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityDatabaseManagerExtensions.GetEntity() not behaving as expected #28

Closed
Fijo opened this issue Apr 16, 2022 · 3 comments · Fixed by #29
Closed

EntityDatabaseManagerExtensions.GetEntity() not behaving as expected #28

Fijo opened this issue Apr 16, 2022 · 3 comments · Fixed by #29
Assignees
Labels

Comments

@Fijo
Copy link
Contributor

Fijo commented Apr 16, 2022

Today I noticed that the EntityDatabaseManagerExtensions.GetEntity(entityDatabase, id) does not work as it is suposed to when using multiple EntityCollections and the entity with the specified id isn't found in the first collection.
An exception is thrown here but the code body in that extension method suggests the writer was assuming it'd collection.GetEntity(id) would return null if there's no entity with the id present in that entity collection.

@grofit grofit self-assigned this Apr 16, 2022
@grofit grofit added the bug label Apr 16, 2022
@grofit
Copy link
Member

grofit commented Apr 16, 2022

I will take a look into it after the bank holiday as I cant do much with kids around, but its probably a left over from when I did the re-write of how components/entities were tracked, so it sounds like a legitimate bug.

As always thanks for taking the time to report it

@grofit
Copy link
Member

grofit commented Apr 23, 2022

This should be fixed within the latest changes on master, however it hasnt been pushed out as a release yet, given this and the next couple of PRs may change the API somewhat I will wait until that is done before I flag it as complete.

@grofit grofit linked a pull request Apr 23, 2022 that will close this issue
@grofit
Copy link
Member

grofit commented May 24, 2022

Im flagging this as closed as I am sure it was done in the previous release, feel free to re-raise if its not.

@grofit grofit closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants