Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Fixes the issue realted to adding/ updating events tags not been saved and making form unsubmissive #10221

Merged

Conversation

amanpreet-dev
Copy link
Contributor

Fixes Issue

Closes #10197

Changes proposed

  • Description field was made required as per the Event schema
  • Commented out setIsDisabled(true) in the handleSubmit() function as this was making the form disabled after inputting the tags.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Creating a new Event
Creating an Event

Updating Event
Updating an Event

Note to reviewers

I have added and updated some sample events locally to test the application flow and it was working fine.

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Feb 5, 2024
Copy link

@luismr00 luismr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new change and everything works. However, the button does not get disabled anymore whenever you are missing a field. This probably does not matter because even if you hit the save button, it will throw an alert if you are missing a field. I would ask another maintainer if they are ok with this, or if they still want the button to become disabled whenever input fields are missing.

@amanpreet-dev
Copy link
Contributor Author

Can I get an update on this PR? if it is still having an issue then please do let me know.

@eddiejaoude eddiejaoude changed the base branch from main to contributions June 8, 2024 10:32
@eddiejaoude
Copy link
Member

Thanks @amanpreet-dev for the PR.

Good spot @luismr00 thank you for testing 👍

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 I will merge and tweak accordingly

@eddiejaoude eddiejaoude merged commit ea110c6 into EddieHubCommunity:contributions Jun 8, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] While adding/ updating events tags are not been saved and making form unsubmissive
4 participants