Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: MhL5 #10325

Merged
merged 3 commits into from
Apr 10, 2024
Merged

data: MhL5 #10325

merged 3 commits into from
Apr 10, 2024

Conversation

MhL5
Copy link
Member

@MhL5 MhL5 commented Apr 8, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Apr 8, 2024
data/MhL5.json Outdated
Comment on lines 3 to 6
"displayStatsPublic": true,
"type": "personal",
"bio": ".....",
"avatar": "https://github.com/MhL5.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove type, avatar, and displayStatsPublic from your json, as we no longer need these. Also, consider adding something in bio too.

Suggested change
"displayStatsPublic": true,
"type": "personal",
"bio": ".....",
"avatar": "https://github.com/MhL5.png",
"bio": ".....",

@MhL5 MhL5 requested a review from kumarsonsoff3 April 9, 2024 10:03
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit 5bdaef6 into EddieHubCommunity:main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants