Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added my profile #1598

Merged
merged 4 commits into from Aug 14, 2022
Merged

Conversation

PritamSarbajna
Copy link
Member

@PritamSarbajna PritamSarbajna commented Aug 14, 2022

Changes proposed

I made a new file called PritamSarbajna.json
there I added my profile

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot (194)

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some formatting issues 🤔

public/data/PritamSarbajna.json Outdated Show resolved Hide resolved
public/data/PritamSarbajna.json Outdated Show resolved Hide resolved
PritamSarbajna and others added 2 commits August 14, 2022 10:41
Co-authored-by: Krish Gupta <krshkodes@gmail.com>
Co-authored-by: Krish Gupta <krshkodes@gmail.com>
Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an endline

public/data/PritamSarbajna.json Outdated Show resolved Hide resolved
Co-authored-by: Krish Gupta <krshkodes@gmail.com>
@Panquesito7 Panquesito7 added the ✍ chore: profile This label will be added on PR with request of Data json addition label Aug 14, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for contributing! 🎉

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Maintainable

Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

__
sema-logo  Summary: 👌 This code looks good  |  Tags: Reusable

@EmmaDawsonDev EmmaDawsonDev merged commit ba64ef9 into EddieHubCommunity:main Aug 14, 2022
@PritamSarbajna PritamSarbajna deleted the new-profile-add branch August 31, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants