Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

Add My Profile : kiritocode1.json #1897

Closed
wants to merge 7 commits into from

Conversation

kiritocode1
Copy link
Member

@kiritocode1 kiritocode1 commented Oct 5, 2022

This PR Proposes Changes to /public/data

Changes Proposed to


Added kiritocode1.json to the directory /public/data .

Check List

  • Compiles to the Code Style of the project ✍️
  • New and Existing test passed
  • Does Not Contain Copyright Exclusive Content of any type .
  • Describes what changes i made .

Screenshots

image
#Note :
please review and merge this PR , Love you 😄

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Welcome @kiritocode1! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions labels Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your profile looks good but you accidentally committed the package lock file. Please use git revert to remove it from your commit.

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes are required in package-lock.json for adding your profile! You can follow this step by step guide to revert the changes from lock file.
Let us know if you need any help with this! :)

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you've deleted the lock file! You're only required to revert the changes from package-lock file.

Just do one thing, copy the whole content from main package-lock file, and paste it in that of your fork!

If you run with any issues, feel free to reach us out!

@EmmaDawsonDev
Copy link
Member

How are you getting on with this @kiritocode1 ?

@kiritocode1
Copy link
Member Author

Sorry @EmmaDawsonDev , i went on a break, ill get back to it monday,

@EmmaDawsonDev
Copy link
Member

No problem at all, just wanted to check in 😊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions large Pull request with more than 30 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants