Added filter to show free and paid events #4759
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
|
Hi! Thank you for working on this. I have a few questions (I have not pulled the code to test yet) What does the mobile experience look like with the added filters? Also, one of the build tests is failing if you are able to take a look at the error |
mobile_view.mp4 |
SaraJaoude
added
issue linked
Hi, the code you are commenting on is part of the playwright tests and not changes included in this PR. To decrease confusion for folks, make sure to only comment on parts of the application and code relevant to this PR. If you believe there are better ways to implement some of the tests you may propose them in a new issue, or start a conversation in ideas in Discord. |
|
Hello @shyam0705 thank you so much for your patience on our reviews of this issue. It got pushed down in priority a bit, but would love to move forward and continue working. You may notice that the branch is now out of date and their are conflicts in a few files. Please pull in main to your branch and see if you are able to fix the merge conflicts. If you are uncomfortable figuring out how to do that or no longer have time to work on this issue please comment and another maintainer will be able to help collaborate on getting this ready for review again. Thank you!!! |
|
Sorry it is my fault I didn't look at this sooner, so I have resolved the conflicts |
|
I will merge into a temporary branch and fix the error and failing test etc |
eddiejaoude
merged commit 061665a
into
EddieHubCommunity:fix-pr-4759
* feat: filter to show free and paid events (#4759) * Added filter to show free and paid events * Move import position for tb coin icon --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * fix: error and formatting * fix: removed search debug code --------- Co-authored-by: Shyam Patel <72148710+shyam0705@users.noreply.github.com>
Fixes Issue
closes #2901
Changes proposed
1)Added filter to show all free and paid events.
2)Modified documentation to suggest adding the startingFrom field in events
Check List (Check all the applicable boxes)
Screenshots
priceFilter.mp4
Note to reviewers