Added a feature which disables the clear button when nothing is selected. #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
the
medium
at-the-vr
reviewed
Mar 22, 2023
eddiejaoude
reviewed
Mar 28, 2023
| @@ -12,7 +12,7 @@ export default function Button({ | |||
| ? " text-white bg-indigo-600 hover:bg-indigo-700" | |||
| : " text-indigo-600 hover:bg-indigo-50"; | |||
| className += disable | |||
| ? " border-2 border-red-600 hover:bg-red-600" | |||
| ? " border-2 border-red bg-[#f4f4f4] hover:bg-[#f3f3f3] opacity-[.5] text-[gray] cursor-not-allowed" | |||
There was a problem hiding this comment.
I think we can use the standard tailwind colours?
eddiejaoude
merged commit 7032164
into
EddieHubCommunity:map-disable-button
10 checks passed
eddiejaoude
reviewed
Mar 28, 2023
| className={`absolute inline-block rotate-0 skew-x-0 skew-y-0 scale-x-100 scale-y-100 py-1 px-1.5 text-xs leading-none text-center whitespace-nowrap align-baseline font-bold bg-orange-600 ${ | ||
| disable ? "text-[#EEEEEE]" : "text-black" | ||
| } ${ | ||
| disable ? "bg-[#C2C2C2]" : "bg-orange-600" |
There was a problem hiding this comment.
I think both disables can be combined into one? I will fix via temporary branch
eddiejaoude
added a commit
that referenced
this pull request
Mar 28, 2023
* feat: disable clear button when no selection (#5588) * Added a feature which disables the clear button when nothing is selected. * Removed unwanted console.log . * fix: map clear tags --------- Co-authored-by: Vedant Manjrekar <93585735+Vedant-Manjrekar@users.noreply.github.com>
|
@eddiejaoude the changes you made in the PR has removed the disabled effect, now both when the button is disabled and when not looks similar. Check it out: It was supposed to look like this: |
|
Yes, locally it worked for me, see the screenshot, but I didn't get a chance to see why when deployed it didn't work correctly
If you have time, feel free to take a look and submit a PR fix, otherwise I can take a look tomorrow |
I'll take care of it. |
|
Great, thank you 👍 |
eddiejaoude
added a commit
that referenced
this pull request
Mar 31, 2023
* feat: disable clear button when no selection (#5588) * Added a feature which disables the clear button when nothing is selected. * Removed unwanted console.log . * fix: map clear tags --------- Co-authored-by: Vedant Manjrekar <93585735+Vedant-Manjrekar@users.noreply.github.com>
eddiejaoude
added a commit
that referenced
this pull request
Mar 31, 2023
* docs: maintainers * data: eddiejaoude (#5523) * fix: removed pull request link to issue check (#5528) * chore(release): v1.100.6 [skip ci] * fix: reviewpad verbose off (#5537) * chore(release): v1.100.7 [skip ci] * data: alcb1310 (#5540) * data: alcb1310 * Update: alcb1310.json Removed the avatar key as requested by the reviewer * data: Chintu1509 (#5531) * Update Chintu1509.json * Update Chintu1509.json * data: Antonio-Riccelli (#5530) * data: update Antonio-Riccelli * data: iriteshmishra (#5536) * data: iriteshmishra * Update iriteshmishra.json * Rename iriteshmishra.json to data/iriteshmishra.json * Update iriteshmishra.json * data: saifrahmn (#5474) * Create saifrahman.json * Update saifrahman.json You can remove the slashes after the links for your blog, instagram and linkedIn has that isnt really needed and the site will load even without that. * Removing slash * Update saifrahman.json * Update public/data/saifrahman.json Co-authored-by: Syed Sohan <63908584+syedsohan@users.noreply.github.com> * Update public/data/saifrahman.json Co-authored-by: David Leal <halfpacho@gmail.com> * adding personal website * Rename saifrahman.json to saifrahmn.json * Update saifrahmn.json * data: saifrahmn * data: saifrahmn * Delete public/data directory * Create saifrahmn.json * Update saifrahmn.json * Update saifrahmn.json * Update saifrahmn.json * Delete saifrahman.json --------- Co-authored-by: Kendall Pinto <kendalldoescoding@gmail.com> Co-authored-by: Syed Sohan <63908584+syedsohan@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * style: format files * fix: bump LinkFree-CLI version to 2.2.2 (#5541) * chore(release): v1.100.8 [skip ci] * data: nerdynikhil (#5532) * data: nerdynikhil * add avatar and make it public * address comments Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * data: aaditya-paul (#5544) * Create aaditya-paul.json * Update data/aaditya-paul.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: rohit190183107010 (#5547) * data: rohit190183107010 * Update data/rohit190183107010.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/rohit190183107010.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: keywordvfx (#5548) * data: loftwah (#5556) * Update loftwah.json * data: SandipPalit (#5552) * Update 2023-03-11-Dare-To-Be-an-Entrepreneur-IWD-2023.json * data: priyankarpal (#5559) * style: format files * fix: move tanitoluwam to data folder (#5573) * chore(release): v1.100.9 [skip ci] * data: AdvaitJain (#5557) * data:AdvaitJain * data: AdvaitJain(updated) * data : sandramsc (#5576) * data : sandramsc * Update sandramsc.json added milestones * Update sandramsc.json * style: format files * data: MohitBansal321 (#5567) * data:MohitBansal321 * data:MohitBansal321 * Update data/MohitBansal321.json Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com> --------- Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com> * data: yhuteemoren (#5586) * data: STIAANWOL (#5582) * data: STIAANWOL * Update data/STIAANWOL.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: otnansirk (#5581) * data: guptaanshik1 (#5578) * data:AnshikGupta * data: AnshikGupta * feat: alias imports (#5579) * feat: path aliases (#3564) (#4543) * [Feature] - Add path aliases (#3564) * Replaced @/ alias with @ --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * fix: shorter imports #3564 --------- Co-authored-by: Vishwanath <FrozenHearth@users.noreply.github.com> * chore(release): v1.101.0 [skip ci] * fix: high outdated dependencies (#5592) * chore(release): v1.101.1 [skip ci] * style: format files * data: Engeniusam (#5585) * data: Engeniusam * Update data/Engeniusam.json * data: qadatta (#5546) * data: qadatta * Update qadatta.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Rename qadatta.json to data/qadatta.json * Update qadatta.json * Update qadatta.json reverted icon spell issue --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: meet931 (#5558) * data: gambhirsharma (#5560) * data:VedantAndhale * Update data/VedantAndhale.json Co-authored-by: Ananya Nayak <ananyanayak102@gmail.com> * Update data/VedantAndhale.json Co-authored-by: Chinmay Mhatre <chinmaymhatre12@gmail.com> * style: format files * feat: playground ui improvements (#5554) * chore(release): v1.102.0 [skip ci] * data: eddiejaoude (#5608) Testimonials updated * data: prathamkandari (#5363) Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> * data: shwetasng (#5365) Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> * data: Amalks920 (#5456) * data: SandipPalit (#5553) * data: Madhavi210 (#5562) * data: Madhavi210 * data: Madhavi210 * Update data/Madhavi210.json Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * Update data/Madhavi210.json Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * data: amithimani (#5564) * data/amithimani * Updated Link with correct Icon * Update amithimani.json * data: Pushpa-Mali (#5577) * data:Pushpa-Mali * Update data/Pushpa-Mali.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: Mohiit70 (#5568) * data: Mohiit70 * Update Mohiit70.json Updated * Update Mohiit70.json Dear Eddie and team, Thank you so much for your help in making my first pull request a success. * data: OkelloSam21.json (#5596) * data: adixit7386 (#5589) * data:adixit7386 * removed avatar Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * updated file nameto data/adixit7386.json --------- Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: Senozoid (#5600) * data: SGsubhash77 (#5599) * data: SGsubhash77 * data: SGsubhash77 * data: Danazumi.json (#5601) * Create Danazumi.json * Update data/Danazumi.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: karthiknadar1204 (#5604) * data:karthiknadar1204 * Update data/karthiknadar1204.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * Update data/karthiknadar1204.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * data: Hittitech (#5602) * data: chirag0002 (#5615) * data: MaSHiNiK.json (#5607) * data: wasup-yash (#5605) * data: Amishapopli1 (#5618) * docs: contributing guide labels (#5610) * chore(release): v1.102.1 [skip ci] * data: boretkiterie (#5616) * data: grand-rick001 (#5620) * data: midhundevasia1 (#5619) * data: midhundevasia1 Modified the profile data * Update data/midhundevasia1.json Co-authored-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com> * style: format files * fix: account stats own visitor (#5595) (#5626) * fix: account stats own visitor (#5595) * added user auth in users api * removed console * getUserApi function changed * Update pages/api/users/[username]/index.js Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * fix: profile increment for owner #5311 * fix: removed debug code --------- Co-authored-by: Akhil Bisht <92508481+Akhilbisht798@users.noreply.github.com> * chore(release): v1.102.2 [skip ci] * fix: stats page increment (#5628) * fix: stats page increment * fix: new import style * chore(release): v1.102.3 [skip ci] * fix: map toggle off tag filter (#5420) (#5447) * fix: map toggle off tag filter (#5420) * fix: change keyword to lowercase to match user tags * chore(release): v1.102.4 [skip ci] * data: grand-rick001 (#5633) * grand-rick001 -- Add Wakatime link * data: oyepriyansh (#5632) * Create oyepriyansh.json * Update data/oyepriyansh.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * data: Senozoid (#5631) * data: nancyKasaudhan20 (#5598) * data: nancyKasaudhan20 * Required changes done * fix: infinite map scroll (#5545) * Fix : Infinite map scroll * Fix: Infinite scrolling * Update Map.js * chore(release): v1.102.5 [skip ci] * docs: formatted readme (#5614) I have added a **NOTE block** for the _note_ written in **GitHub UI** section and added _links_ to _specific sections_ of the README file for **better accessibility**. * chore(release): v1.102.6 [skip ci] * style: format files * data: utkarshkrishna2004 (#5642) * data: utkarshkrishna2004 * Update data/utkarshkrishna2004.json Co-authored-by: David Leal <halfpacho@gmail.com> --------- Co-authored-by: David Leal <halfpacho@gmail.com> * fix: nav links state not persisted with deep links (#5197) * fix: NavLink active state not persist * fix: Validate 'item' prop to NavLink * chore(release): v1.102.7 [skip ci] * data: yaser-alazm (#5651) * data: yaser-alazm * remove avatar entry * data: abrokinla (#5645) * fix: prevent eventcard overflow (#4840) (#5143) Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * chore(release): v1.102.8 [skip ci] * style: format files * data: yoyoekta (#5649) Added shortcuts, tags and updated links section. * fix: removed extra space from testimonials (#5648) * Removed extra space from testimonials.js * Update Testimonials.js * Update components/Testimonials.js --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> * chore(release): v1.102.9 [skip ci] * data:Landouda (#5643) * data:Landouda * data: Landouda fix --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> * style: format files * data: mrdanishsaleem (#5664) Update mrdanishsaleem.json 💼: Add showwcase link * data: tarunclub (#5663) * data: tarunclub * Update data/tarunclub.json Co-authored-by: Ved Prakash Nautiyal <v3dprakashnautiyal@gmail.com> --------- Co-authored-by: Ved Prakash Nautiyal <v3dprakashnautiyal@gmail.com> * data: ShubhamMore6688 (#5662) * data: ShubhamMore6688 * data: ShubhamMore6688 * data: durgaprasad118 (#5661) * data: durgaprasad118 * Update data/durgaprasad118.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: OmSoni-1 (#5660) * data: OmSoni-1 * Delete OmSoni-1.json * data: OmSoni-1 * map zoom fixed * chore(release): v1.102.10 [skip ci] * data: 1010nishant (#5675) Update 1010nishant.json * data: dineshlalam15 (#5672) * data dineshlalam15 * I've removed "avatar" and the image link in the code as requested. * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * data: Ellah120 (#5671) * data: durgaprasad118 (#5670) * data: geeky-sambhav (#5656) * data: geeky-sambhav * Fixed broken urls and added data/ before the name * style: format files * feat: map disable clear tag filter (#5678) * feat: disable clear button when no selection (#5588) * Added a feature which disables the clear button when nothing is selected. * Removed unwanted console.log . * fix: map clear tags --------- Co-authored-by: Vedant Manjrekar <93585735+Vedant-Manjrekar@users.noreply.github.com> * chore(release): v1.103.0 [skip ci] * data: tobySolutions (#5682) * Update tobySolutions.json * Update tobySolutions.json * data: Shalini469717 (#5668) * Create Shalini469717.json * Update data/Shalini469717.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: thekrprince (#5673) * Create thekrprince.json * Update data/thekrprince.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * style: format files * fix: map clear topics button (#5701) * fix: disabled button for map (#5681) * Fix for the disabled effect of Button component. * removed 'primary' style option as it seems unnecessary. * Fixed disabled effect, removed unwanted changes. * removed unwanted changes. * fix: unrequired code changes --------- Co-authored-by: Vedant Manjrekar <93585735+Vedant-Manjrekar@users.noreply.github.com> * chore(release): v1.103.1 [skip ci] * data: Jahan2003 (#5698) * data: iamunnip(#5694) * data: linneszyx (#5690) * data: linneszyx * data: linneszyx.json * data: Paiman-Rasoli (#5686) * style: format files * add: moonLight-7k (#5705) * Create moonLight-7k * Rename moonLight-7k to moonLight-7k.json * Update moonLight-7k.json * data: Goketech (#5707) * data: goketech * Rename goketech.json to Goketech.json * data: Manoj-71 (#5703) * feat: profile progress bar (#5713) * feat: profile progress bar (#5617) * add functionality to calculate the percentage and the missing property * percentage functionality added to ui basic buttons added basic hint added with title and icon * progress bar complete removed hints section * removed test data * removed dark variant on the progress bar * remove react import * add testimonials and format * feat: profile progress bar #5496 * data: eddiejaoude --------- Co-authored-by: Chinmay Mhatre <chinmaymhatre12@gmail.com> * chore(release): v1.104.0 [skip ci] * data: jaswanth187 (#5708) * data: jaswanth187 * Rename public/data/jaswanth187.json to data/jaswanth187.json * data: ramanand-rv (#5667) * data: ramanand-rv * updated and moved the json file to data folder * Updated icon value for YouTube * data: PetrusHimself (#5692) * data: dineshlalam15 (#5706) * data: dineshlalam15 * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * Update data/dineshlalam15.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> * Update data/dineshlalam15.json Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> --------- Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * add: Kevinkp09 (#5696) * data: iamvbenz49 (#5684) * data: iamvbenz49 * data: iamvbenz49 * data: roberanegussie (#5689) * data: roberanegussie * Corrected the line errors. * Testimonial for 'sahil-sagwekar2652' by 'Shubham185y' * Testimonial for 'Shubham185y' by 'sahil-sagwekar2652' * data:Junnygram * update Anmol-Baranwal data * data : Nikhilfy * Update Nikhilfy.json * Update data/Nikhilfy.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/Nikhilfy.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * style: format files * docs: screenshots in readme (#5731) * chore(release): v1.104.1 [skip ci] * data: BenceDv (#5691) * data: BenceDv * Update data/BenceDv.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/BenceDv.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/BenceDv.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/BenceDv.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * data: AJcodes42 (#5709) * data:AJcodes42 * data: AJcodes42 * relocate to data/AJcodes42.json * data: B2prakash (#5674) * data:B2prakash * Update data/B2prakash.json * data: ApurvaBasule (#5726) * data : ApurvaBasule * Update data/ApurvaBasule.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/ApurvaBasule.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> * Update data/ApurvaBasule.json Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> --------- Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> * docs: maintainers guide --------- Co-authored-by: Conventional Changelog Action <conventional.changelog.action@github.com> Co-authored-by: Andres Court <97707578+alcb1310@users.noreply.github.com> Co-authored-by: Vengala-Uday <126854795+Chintu1509@users.noreply.github.com> Co-authored-by: Antonio Riccelli <anton.riccelli@gmail.com> Co-authored-by: Ritesh Mishra <96378085+iriteshmishra@users.noreply.github.com> Co-authored-by: Saif Rahman <64410006+saifrahmn@users.noreply.github.com> Co-authored-by: Kendall Pinto <kendalldoescoding@gmail.com> Co-authored-by: Syed Sohan <63908584+syedsohan@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Pradumnasaraf <Pradumnasaraf@users.noreply.github.com> Co-authored-by: Pradumna Saraf <pradumnasaraf@gmail.com> Co-authored-by: Nikhil Barik <nklmarch17@gmail.com> Co-authored-by: Priyanshu kumawat <88786642+kumarsonsoff3@users.noreply.github.com> Co-authored-by: Aaditya Paul <91450480+aaditya-paul@users.noreply.github.com> Co-authored-by: Sara Jaoude <82668196+SaraJaoude@users.noreply.github.com> Co-authored-by: Khushal Arora <khushalcosmos26@gmail.com> Co-authored-by: Rohit <91536468+rohit190183107010@users.noreply.github.com> Co-authored-by: keywordvfx <127814741+keywordvfx@users.noreply.github.com> Co-authored-by: Dean Lofts <dean@deanlofts.xyz> Co-authored-by: Sandip Palit <48781286+SandipPalit@users.noreply.github.com> Co-authored-by: Priyankar Pal <88102392+priyankarpal@users.noreply.github.com> Co-authored-by: Advait Jain <89680252+Zoronium@users.noreply.github.com> Co-authored-by: Sandra Ashipala <sandraashipala@gmail.com> Co-authored-by: Mohit Bansal <78220157+MohitBansal321@users.noreply.github.com> Co-authored-by: Yhutee Moren <80987535+yhuteemoren@users.noreply.github.com> Co-authored-by: Stiaan Wolfaardt <stiaan99@gmail.com> Co-authored-by: Kris <krisnantobiyuh@gmail.com> Co-authored-by: guptaanshik <61491962+guptaanshik1@users.noreply.github.com> Co-authored-by: Vishwanath <FrozenHearth@users.noreply.github.com> Co-authored-by: Samuel Macharia <67005722+Engeniusam@users.noreply.github.com> Co-authored-by: Dattatrya More <qadatta@users.noreply.github.com> Co-authored-by: Mitesh Chaudhari <109075376+meet931@users.noreply.github.com> Co-authored-by: Gambhir Sharma <gambhir786191ss@gmail.com> Co-authored-by: Vedant Andhale <90826179+VedantAndhale@users.noreply.github.com> Co-authored-by: Ananya Nayak <ananyanayak102@gmail.com> Co-authored-by: Chinmay Mhatre <chinmaymhatre12@gmail.com> Co-authored-by: Saikat Mandal <75900118+Saikat-Mandal@users.noreply.github.com> Co-authored-by: Pratham Kandari <112901447+prathamkandari@users.noreply.github.com> Co-authored-by: Shweta Singh <103261868+shwetasng@users.noreply.github.com> Co-authored-by: Amalks920 <110404020+Amalks920@users.noreply.github.com> Co-authored-by: Madhavi Joshi <109155050+Madhavi210@users.noreply.github.com> Co-authored-by: amithimani <56103789+amithimani@users.noreply.github.com> Co-authored-by: Pushpa Mali <94977416+Pushpa-Mali@users.noreply.github.com> Co-authored-by: Mohit Bisht <120316966+Mohiit70@users.noreply.github.com> Co-authored-by: SAMUEL <115361239+OkelloSam21@users.noreply.github.com> Co-authored-by: Abhay Dixit <adixit7386@gmail.com> Co-authored-by: Senozoid <93595764+Senozoid@users.noreply.github.com> Co-authored-by: SGsubhash77 <65059926+SGsubhash77@users.noreply.github.com> Co-authored-by: Danazumi <86608142+Danazumi@users.noreply.github.com> Co-authored-by: karthik nadar <karthiknadar1204@gmail.com> Co-authored-by: Md Adnan Sami <87484115+Hittitech@users.noreply.github.com> Co-authored-by: Chirag Varshney <87241050+chirag0002@users.noreply.github.com> Co-authored-by: MaSHiNiK <80310257+MaSHiNiK@users.noreply.github.com> Co-authored-by: yash sharma <112958086+wasup-yash@users.noreply.github.com> Co-authored-by: Amishapopli1 <93682469+Amishapopli1@users.noreply.github.com> Co-authored-by: boretkiterie <99145013+boretkiterie@users.noreply.github.com> Co-authored-by: Patrick Murimi <kabugap02@gmail.com> Co-authored-by: MIDHUN DEVASIA <midhundevasia1@gmail.com> Co-authored-by: Akhil Bisht <92508481+Akhilbisht798@users.noreply.github.com> Co-authored-by: Wei-Lin Cheng <7236196+weilincheng@users.noreply.github.com> Co-authored-by: Priyansh Prajapat <priyansh029ztn@gmail.com> Co-authored-by: Nancy Kasaudhan <97733705+nancyKasaudhan20@users.noreply.github.com> Co-authored-by: SANSKAR KABRA <sanskarkabra1306@gmail.com> Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com> Co-authored-by: Utkarsh Krishna <utkarshmark14@gmail.com> Co-authored-by: Harshdeep Singh <94737463+JunDevHarsh@users.noreply.github.com> Co-authored-by: Yaser AlAzm <yaser.azem@gmail.com> Co-authored-by: Araoye Abraham <abrokinla@gmail.com> Co-authored-by: Gaurav Burande <100035026+GauravBurande@users.noreply.github.com> Co-authored-by: Ekta <92643605+yoyoekta@users.noreply.github.com> Co-authored-by: Landouda <119908341+Landouda@users.noreply.github.com> Co-authored-by: Danish <danish_s@outlook.com> Co-authored-by: Tarun Kumar <102040059+tarunclub@users.noreply.github.com> Co-authored-by: Ved Prakash Nautiyal <v3dprakashnautiyal@gmail.com> Co-authored-by: Shubham More <94038708+ShubhamMore6688@users.noreply.github.com> Co-authored-by: Achana Naga Durga Prasad <108184152+durgaprasad118@users.noreply.github.com> Co-authored-by: Om Soni <omsoni833@gmail.com> Co-authored-by: Anik Dhabal Babu <adhabal2002@gmail.com> Co-authored-by: Nishant-Kumar-Jangid <88904952+1010nishant@users.noreply.github.com> Co-authored-by: Dinesh Kumar Lalam <dineshlalam15@gmail.com> Co-authored-by: Nwoke Ogechi Emmanuella <98160154+Ellah120@users.noreply.github.com> Co-authored-by: Sambhav Gandhi <83087385+geeky-sambhav@users.noreply.github.com> Co-authored-by: Vedant Manjrekar <93585735+Vedant-Manjrekar@users.noreply.github.com> Co-authored-by: Tobiloba Adedeji <96334363+tobySolutions@users.noreply.github.com> Co-authored-by: Shalini <99305545+Shalini469717@users.noreply.github.com> Co-authored-by: Kumar Prince <39616644+thekrprince@users.noreply.github.com> Co-authored-by: Jahan Sai <91596914+Jahan2003@users.noreply.github.com> Co-authored-by: Unni P <unnipofficial@outlook.com> Co-authored-by: Suryansh Upadhyay <itssuryanshcooldude346@gmail.com> Co-authored-by: Paiman Rasoli <83835010+Paiman-Rasoli@users.noreply.github.com> Co-authored-by: Suhel Khan <suhelkhan87514@gmail.com> Co-authored-by: Akanni Modupe Adegoke <modupe775@gmail.com> Co-authored-by: Manoj Kumar Sahoo <112793753+Manoj-71@users.noreply.github.com> Co-authored-by: Jaswanth <67514357+jaswanth187@users.noreply.github.com> Co-authored-by: Ramanand Thakur <80584888+ramanand-rv@users.noreply.github.com> Co-authored-by: Petrus Tlhomedi <tlhomedipetrus@gmail.com> Co-authored-by: Kevin Patel <kevinpatel907.kp@gmail.com> Co-authored-by: Sham Vijay <benzwrites@gmail.com> Co-authored-by: Robera Negussie Toye <47657043+roberanegussie@users.noreply.github.com> Co-authored-by: Shubham185y <Shubham185y@users.noreply.github.com> Co-authored-by: sahil-sagwekar2652 <sahil-sagwekar2652@users.noreply.github.com> Co-authored-by: Olaleye <90139191+Junnygram@users.noreply.github.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Nikhilfy <123803971+Nikhilfy@users.noreply.github.com> Co-authored-by: BenceDv <92792173+BenceDv@users.noreply.github.com> Co-authored-by: Ajay Singh <ajaysingh942@gmail.com> Co-authored-by: Ved prakash <124797314+B2prakash@users.noreply.github.com> Co-authored-by: ApurvaBasule <97452527+ApurvaBasule@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5500
closes #5500
Changes proposed
Currently
Clear/Resetbutton in Map section is active even when no filter is selected, hence a fix to this issue is proposed through my PR which disables the button if no filters are selected.Before:
After:
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers