-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix:Automatically unlock issue (#6770) #7269
fix:Automatically unlock issue (#6770) #7269
Conversation
Replaced repo-lockdown with label-actions as label-actions has both lock and unlock functionality and developed by the same developer. Here two things happen
|
Looks like there's a bug where unlocking the issue goes Update : raised here dessant/label-actions#23 |
This seems to happen only when you have a comment while unlocking an issue (Like we have) |
Oh I see, is this a blocker for us to use it? Should we wait until it is fixed on the original repo? |
I think we are 2 options:
I would personally prefer option 2, as adding an extra comment while unlocking makes the issue thread unnecessarily long. let me know, which one you think is best, and I'll make changes accordingly. thanks |
We do often comment, so we might have to wait for the release |
Sure, Eddie, I'll watch the repo and make the changes when a new release comes out. And also, let me know what you would like to have as a comment while unlocking ! |
Awesome! I will mark this as block for now, and we can unblock it when the fix is released 馃憤 I will check the text also 馃憤 |
'馃弫 status: ready for dev': | ||
issues: | ||
comment: > | ||
The thread has been temporarily unlocked.Please follow our community guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change this to something informative.
Awesome 馃憤 Thank you! I will tale a look at merging this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 馃憤 , I will merge to a temporary branch and have a play
Fixes Issue
Resolves #6770
Check List (Check all the applicable boxes)
Screenshots
When the
![image](https://private-user-images.githubusercontent.com/54185106/241957438-7284dd21-cd0a-4eae-a1e0-fbe7fb212f3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0Njg3NjgsIm5iZiI6MTcyMDQ2ODQ2OCwicGF0aCI6Ii81NDE4NTEwNi8yNDE5NTc0MzgtNzI4NGRkMjEtY2QwYS00ZWFlLWExZTAtZmJlN2ZiMjEyZjNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDE5NTQyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE2MDgwMjExYWEwZGZkMWIxNDBjNmMzYjJhMjQ3YjY2MjUzZDYzZTI2MTE0OWI4YTczNDVlOWQxYzg4MWM5YzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WhQuRyDy81bqpFDVAqPVmJ8BeSQSyyLptNHZ-c7KO1s)
![image](https://private-user-images.githubusercontent.com/54185106/241959400-da931020-ec82-411e-9d1f-f6127b1168e7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0Njg3NjgsIm5iZiI6MTcyMDQ2ODQ2OCwicGF0aCI6Ii81NDE4NTEwNi8yNDE5NTk0MDAtZGE5MzEwMjAtZWM4Mi00MTFlLTlkMWYtZjYxMjdiMTE2OGU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDE5NTQyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkyNjIzZjg3YzVjMGY4ODRiOTZjNDA4ZmQ3ODQ0ZjFhZmZhMzU3ZTAxMTg1Mzk0NGE2OTg5MDNiZWZjNThhYTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Z33iVBgM83-yzmjaU2dqmb0ZzDJaBGCYHOuc6yRWxQM)
馃殾 status: awaiting triage
label is added, it auto-locks the issue :When
馃弫 status: ready for dev
is added, auto unlocks the issue :Note to reviewers
Replaced repo-lockdown with label-actions as
label-actions
has both lock and unlock functionality and developed by the same developer.