Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

fix:Automatically unlock issue (#6770) #7269

Merged
merged 7 commits into from
Jun 10, 2023
Merged

fix:Automatically unlock issue (#6770) #7269

merged 7 commits into from
Jun 10, 2023

Conversation

nitheesh-daram
Copy link
Member

@nitheesh-daram nitheesh-daram commented May 30, 2023

Fixes Issue

Resolves #6770

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

When the 馃殾 status: awaiting triage label is added, it auto-locks the issue :
image
When 馃弫 status: ready for dev is added, auto unlocks the issue :
image

Note to reviewers

Replaced repo-lockdown with label-actions as label-actions has both lock and unlock functionality and developed by the same developer.

@github-actions github-actions bot added large Pull request with more than 30 changed lines waiting-for-reviewers labels May 30, 2023
@nitheesh-daram
Copy link
Member Author

Replaced repo-lockdown with label-actions as label-actions has both lock and unlock functionality and developed by the same developer.

Here two things happen

  1. It will lock the issue when the 馃殾 status: awaiting triage label is added, irrespective of other labels.
  2. It will Unlock the issue when the 馃弫 status: ready for dev label is added, irrespective of other labels.

@nitheesh-daram
Copy link
Member Author

nitheesh-daram commented May 30, 2023

Looks like there's a bug where unlocking the issue goes unlocks -> locks again -> unlocks, will raise an issue in the label-actions repo.

Update : raised here dessant/label-actions#23

@nitheesh-daram
Copy link
Member Author

Looks like there's a bug where unlocking the issue goes unlocks -> locks again -> unlocks, will raise an issue in the label-actions repo.

Update : raised here dessant/label-actions#23

This seems to happen only when you have a comment while unlocking an issue (Like we have)

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label May 31, 2023
@eddiejaoude
Copy link
Member

Looks like there's a bug where unlocking the issue goes unlocks -> locks again -> unlocks, will raise an issue in the label-actions repo.
Update : raised here dessant/label-actions#23

This seems to happen only when you have a comment while unlocking an issue (Like we have)

Oh I see, is this a blocker for us to use it? Should we wait until it is fixed on the original repo?

@nitheesh-daram
Copy link
Member Author

nitheesh-daram commented Jun 7, 2023

Oh I see, is this a blocker for us to use it? Should we wait until it is fixed on the original repo?

I think we are 2 options:

  1. if we want a comment while unlocking, we need to wait for the new release (it's already fixed here(dessant/label-actions@8ebc35d) in the code part, but the owner has yet to release the new version).
  2. if we don't want a comment while unlocking, we are good to go!

I would personally prefer option 2, as adding an extra comment while unlocking makes the issue thread unnecessarily long.

let me know, which one you think is best, and I'll make changes accordingly.

thanks

@eddiejaoude
Copy link
Member

We do often comment, so we might have to wait for the release

@nitheesh-daram
Copy link
Member Author

We do often comment, so we might have to wait for the release

Sure, Eddie, I'll watch the repo and make the changes when a new release comes out.

And also, let me know what you would like to have as a comment while unlocking !
I suggest making it informative, like linking to docs on commit style,pr creation, rather than normal comments.

@eddiejaoude
Copy link
Member

Awesome! I will mark this as block for now, and we can unblock it when the fix is released 馃憤

I will check the text also 馃憤

@nitheesh-daram
Copy link
Member Author

Awesome! I will mark this as block for now, and we can unblock it when the fix is released +1

I will check the text also +1

Hey Eddie, the developer released a new release, and it looks like we don't need any changes from our end; we are good to merge!

image

'馃弫 status: ready for dev':
issues:
comment: >
The thread has been temporarily unlocked.Please follow our community guidelines.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this to something informative.

@eddiejaoude
Copy link
Member

Awesome 馃憤 Thank you! I will tale a look at merging this tomorrow

@eddiejaoude eddiejaoude changed the base branch from main to test-pr-7269 June 10, 2023 04:22
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 馃憤 , I will merge to a temporary branch and have a play

@eddiejaoude eddiejaoude merged commit ae3ddc1 into EddieHubCommunity:test-pr-7269 Jun 10, 2023
3 checks passed
eddiejaoude added a commit that referenced this pull request Jun 10, 2023
* fix: automatically unlock issue by labels (#6770) (#7269)

* fix: github actions

---------

Co-authored-by: Nitheesh Daram <54185106+nitheesh-daram@users.noreply.github.com>
@nitheesh-daram nitheesh-daram deleted the ISSUE-6770 branch June 10, 2023 05:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked large Pull request with more than 30 changed lines 馃毀 status: blocked undefined waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] GitHub bot should unlock conversation once '馃弫 status: ready for dev' label is added
3 participants