This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
fix: The delete button's text color has been changed from black to white #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when deleting any link.
github-actions
bot
added
small
|
Reviewpad Report ℹ️ Messages
|
amandamartin-dev
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #8029
Changes proposed
Previously, when a link was deleted in dark mode, the text colour of the delete button used to be black. This was not visually appealing. But now, the text colour of the delete button has been updated and changed to white, which is a more suitable and visually pleasing colour choice.
Check List (Check all the applicable boxes)
Screenshots
before
after
Note to reviewers