Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Milestones section #2123

Merged
merged 1 commit into from Nov 5, 2022
Merged

Updated Milestones section #2123

merged 1 commit into from Nov 5, 2022

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Nov 5, 2022

Fixes Issue

Changes proposed

I updated my Milestones Section

Check List (Check all the applicable boxes)

  • [ X] My code follows the code style of this project.
  • [X ] My change requires changes to the documentation.
  • [X ] I have updated the documentation accordingly.
  • [ X] All new and existing tests passed.
  • [ X] This PR does not contain plagiarized content.
  • [X ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hi Eddie! I finally formatted my JSON file.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added large Pull request with more than 30 changed lines v2 labels Nov 5, 2022
@eddiejaoude eddiejaoude changed the base branch from nextjs to main November 5, 2022 08:40
@eddiejaoude eddiejaoude changed the base branch from main to nextjs November 5, 2022 08:41
@eddiejaoude
Copy link
Member

eddiejaoude commented Nov 5, 2022

Please make data changes to the the main branch, otherwise, when we merge + deploy v2 they will get lost

@eddiejaoude eddiejaoude added the ✍ chore: profile This label will be added on PR with request of Data json addition label Nov 5, 2022
@eddiejaoude eddiejaoude changed the base branch from nextjs to main November 5, 2022 16:47
@eddiejaoude eddiejaoude merged commit 2732207 into EddieHubCommunity:main Nov 5, 2022
@CBID2 CBID2 deleted the patch-1 branch November 5, 2022 17:01
@github-actions github-actions bot added the LGTM label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✍ chore: profile This label will be added on PR with request of Data json addition large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants