Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Changed word in line 62. Updated milestone section#2120

Closed
CBID2 wants to merge 1 commit intoEddieHubCommunity:mainfrom
CBID2:chrissy-branch
Closed

Changed word in line 62. Updated milestone section#2120
CBID2 wants to merge 1 commit intoEddieHubCommunity:mainfrom
CBID2:chrissy-branch

Conversation

@CBID2
Copy link
Copy Markdown
Contributor

@CBID2 CBID2 commented Nov 4, 2022

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • [x ] My code follows the code style of this project.
  • [x ] My change requires changes to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [ x] All new and existing tests passed.
  • [ x] This PR does not contain plagiarized content.
  • [ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hey Eddie! :) I followed your suggestions. Let me know if more improvements are needed. (Note: in lines 30-31 in my JSON file, I used the GitHub icon and its color because there is no other icon or color for scholarships and other awards.)

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions Bot added small Pull request with less than 10 changed lines ✍ chore: profile This label will be added on PR with request of Data json addition labels Nov 4, 2022
Comment thread public/data/CBID2.json
"color": "grey",
"description":"Shesharp is a non-profit foundation that is dedicated to helping women and non-binary people start their careers in tech. I received this award as a result of expressing my interest in bridging the gaps between instructional design and coding in addtion to being an active member in SheSharp's Slack community.",
"url": "https://www.linkedin.com/posts/shesharp_announcing-our-new-in-tech-scholarship-winner-activity-6993866371780476928-q5-3?utm_source=share&utm_medium=member_desktop",
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the GitHub Action inline comments about the invalid json

Also json file change should go to main branch (but the README changes should be to the nextjs branch)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. How do I make sure the README file changes go into the mainJS?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new branch from the default branch for each separate change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lost

@eddiejaoude
Copy link
Copy Markdown
Member

Going to close PR as it is a duplicate of
#2124
#2123

@eddiejaoude eddiejaoude closed this Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

✍ chore: profile This label will be added on PR with request of Data json addition small Pull request with less than 10 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants