fix: map toggle off tag filter (#5420)

[weilincheng]

Fixes Issue

Closes #5420

Changes proposed

Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• My change requires changes to the documentation.
• I have updated the documentation accordingly.
• All new and existing tests passed.
• This PR does not contain plagiarized content.
• The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

This commit updates the user filtering logic to use the tags in the updatedSelectedTags as filter conditions.

If there are any concerns or suggestions regarding this approach, please let me know. Thank you for your time and consideration.

[github-actions]

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[eddiejaoude]

The map results do not seem to change for me when toggling on/off tags

[Ananya2001-an]

Hey @weilincheng you can implement something like this for the filterData function. I tested it and it's working. The code addition return updatedSelectedTags; is correct. Keep that and just implement this for filterData().

const filterData = async (value) => {
      const selectedTagsArray = [...(await updateSelectedTagsFilter(value))];
      
      if(selectedTagsArray.length === 0){
        setFilteredUsers([]);
      }
   
      else{
        results = users.filter((user) => {
         
          if (selectedTagsArray.every(tag => user.name.toLowerCase().includes(tag.toLowerCase()))) {
            return true;
          }
  
          let userTags = user.tags?.map((tag) => tag.toLowerCase());
  
          if (selectedTagsArray.every((tag) => userTags?.includes(tag.toLowerCase()))) {
            return true;
          }
  
          return false;
        });
  
        setFilteredUsers(results);
      }
  };

https://www.awesomescreenshot.com/video/15630826?key=96eaea61948712ffae4c5a7746bf6588

[weilincheng]

Hey @weilincheng you can implement something like this for the filterData function. I tested it and it's working. The code addition return updatedSelectedTags; is correct. Keep that and just implement this for filterData().

Hi @Ananya2001-an, thank you for taking the time to provide your suggestion! Your insights are much appreciated. I will review and analyze why my initial implementation didn't work and consider your suggestions as part of my revisions. Thanks again for your valuable input!

[Ananya2001-an]

Hey @weilincheng you can implement something like this for the filterData function. I tested it and it's working. The code addition return updatedSelectedTags; is correct. Keep that and just implement this for filterData().

Hi @Ananya2001-an, thank you for taking the time to provide your suggestion! Your insights are much appreciated. I will review and analyze why my initial implementation didn't work and consider your suggestions as part of my revisions. Thanks again for your valuable input!

Sure @weilincheng I am more than happy to help 🙂

[weilincheng]

Hi @Ananya2001-an, thank you for taking the time to provide your suggestion! Your insights are much appreciated. I will review and analyze why my initial implementation didn't work and consider your suggestions as part of my revisions. Thanks again for your valuable input!

Sure @weilincheng I am more than happy to help 🙂

Hi @Ananya2001-an,

I understand why my previous commit wasn't successful. In short, I used fake user data for testing purposes, which only included tags in lowercase. This is why my previous change, which did not convert selected tags to lowercase, seemed to work. I have since converted the selected tags to lowercase, so it will work with real user data!

I used fake user data because I was unsure of how user location information is populated. To address this, I have created issue #5473.

Thank you!!

[Ananya2001-an]

Amazing @weilincheng 👏 yeah what you are saying is right. Thanks for acknowledging and I appreciate the detailed explanation 😊

[eddiejaoude]

Looks good! Great collaboration 👍