Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Using bower #31

Closed
igorissen opened this issue Feb 9, 2015 · 4 comments
Closed

[Question] Using bower #31

igorissen opened this issue Feb 9, 2015 · 4 comments

Comments

@igorissen
Copy link

Hi,

For my Angular project, I'm using Bower. So I've executed this command because there isn't (for now) a bower package for your library :

bower install --save https://github.com/EddieLa/JOB.git

It works great. First question: did you intend to create a bower package for your library ?
Now when you include the library

...
<script src="assets/vendor/JOB/src/JOB.js"></script>
...

and call the init function

...
JOB.Init();
...

these lines place some issues

...
DecoderWorker: new Worker("DecoderWorker.js"),
...
Init: function () {
...
script.src = "exif.js";
...
}

because DecoderWorker.js and exif.js have a wrong file path. If I want your library to work I need to change your code to

...
DecoderWorker: new Worker("assets/vendor/JOB/src/DecoderWorker.js"),
...
Init: function () {
...
script.src = "assets/vendor/JOB/src/exif.js";
...
}

and it's a complicated when you want to deploy your application. Maybe it would be better to add the DecoderWorker.js and exif.js files like your library

<script src="path/to/DecoderWorker.js"></script>
<script src="path/to/exif.js"></script>
<script src="path/to/JOB.js"></script>

What do you think about this?

@EddieLa
Copy link
Owner

EddieLa commented Feb 9, 2015

Hi,

I had not intented to make a bower package, I had in fact never heard of bower until you mentioned.
I'm not actually very involved in web or javascript development I mostly do .net/java so I'm afraid I can't really help you here.

@igorissen
Copy link
Author

Ok. I will try to create a bower package for your library. It's also the first time for me.

@seabornlee
Copy link

Bower is very popular in front-end community. I must be great to have the library in bower repository.

@seangates
Copy link

@igorissen Did you get the Bower fork working? I created one for NPM with this most recent pull request. I'm sure Bower would be really easy to get going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants