Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout repository recursively in Github action #413

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

peterstadler
Copy link
Member

Description, Context and related Issue

@obertsalome and I were testing the current build artifact and realized that the TEI Stylesheets were missing in the EOL xar which caused the Edirom to fail miserably. Introducing submodules: 'recursive' will hopefully fix this – or is there any reason to exclude the submodules from the build here?

Refs #370

How Has This Been Tested?

Not at all

Types of changes

  • New feature (non-breaking change which adds functionality)

@bwbohl
Copy link
Member

bwbohl commented Sep 5, 2024

Many thanks for spotting this!

@bwbohl bwbohl added Type: bugfix A pull request providing a bugfix Area: Build & deploy labels Sep 5, 2024
@bwbohl bwbohl added this to the 1.0.0 milestone Sep 5, 2024
Salome and I were testing the current build artifact and realized that the TEI Stylesheets were missing in the EOL xar which caused the Edirom to fail miserably. 
Introducing `submodules: 'recursive'` will hopefully fix this – or is there any reason to exclude the submodules from the build here?
@peterstadler peterstadler merged commit d31d591 into develop Sep 6, 2024
1 check passed
@peterstadler peterstadler deleted the peterstadler-patch-1 branch September 6, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build & deploy Type: bugfix A pull request providing a bugfix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants