Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to document that FeatureSets will be unequal when instances are ordered differently #272

Closed
desilinguist opened this issue Dec 30, 2015 · 2 comments
Assignees
Milestone

Comments

@desilinguist
Copy link
Member

If we read in two feature files where all the instances are exactly the same but just ordered differently, the resulting FeatureSets will not be equal to each other. Is this to be expected? Should ordering really matter for a FeatureSet or should two FeatureSets be deemed equal as long as all the feature values are the same for the same instances?

Now that I think about it, I am not sure we can really address this issue because this would mean re-ordering/sorting stuff after the file has been read which could be very inefficient for large feature files. However, we should probably document this in the API and the code - that ordering matters for FeatureSets.

@dan-blanchard
Copy link
Contributor

Yeah, part of how we're efficient is by not sorting things. Also, as we all know, example order matters a lot for learning, so I think we should just document that ordering matters.

@dan-blanchard dan-blanchard changed the title Featuresets may be incorrectly unequal because instances are ordered differently Need to document that FeatureSets will be unequal when instances are ordered differently Dec 30, 2015
@desilinguist desilinguist added this to the 1.2 milestone Jan 26, 2016
@aoifecahill aoifecahill self-assigned this Feb 12, 2016
@desilinguist
Copy link
Member Author

Addressed by #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants