Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientBoostingClassifier and GradientBoostingRegressor should support sparse matrices #428

Closed
SimengSun opened this issue Jul 19, 2018 · 4 comments

Comments

@SimengSun
Copy link

SimengSun commented Jul 19, 2018

MemoryError will be raised for large training data when using GBC (It converts sparse training data to dense first). GBC in sklearn does support sparse matrices as input and works well.

@desilinguist desilinguist changed the title GradientBoostingClassifier learner does not support sparse matrices GradientBoostingClassifier and GradientBoostingRegressor should support sparse matrices Jul 20, 2018
@desilinguist
Copy link
Member

SKLL currently expects the following learners to take only dense matrices as input:

_REQUIRES_DENSE = (BayesianRidge,
                   GradientBoostingClassifier,
                   GradientBoostingRegressor,
                   Lars,
                   TheilSenRegressor)

I double checked and other than the gradient boosted learners, the others take dense matrices as expected.

@stale
Copy link

stale bot commented Oct 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 18, 2018
@desilinguist
Copy link
Member

Keep it open please.

@stale stale bot removed the stale label Oct 18, 2018
@desilinguist
Copy link
Member

Addressed by #429.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants